-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: init metrics with constlabls #53380
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Hi @zeminzhou. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: zzm <zhouzemin@pingcap.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53380 +/- ##
================================================
+ Coverage 72.6008% 74.6611% +2.0602%
================================================
Files 1505 1505
Lines 429827 431037 +1210
================================================
+ Hits 312058 321817 +9759
+ Misses 98576 89304 -9272
- Partials 19193 19916 +723
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -279,7 +279,7 @@ func main() { | |||
os.Exit(0) | |||
} | |||
registerStores() | |||
err := metricsutil.RegisterMetrics() | |||
err := metricsutil.RegisterMetricsWithLabels(config.GetGlobalConfig().MetricsLabels) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some test case for labels!=nil
Signed-off-by: zzm <zhouzemin@pingcap.com>
/test unit-test |
@zeminzhou: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test unit-test |
@zeminzhou: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@zeminzhou: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #53383
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.