added lint checker in CI and fixes lint errors #253
Conversation
Signed-off-by: Omkar <opkulkarni0104@gmail.com>
| s.relayMutex.RLock() | ||
| now := time.Now().Unix() | ||
| if relayList, ok := s.RelayMap[req.ou]; ok { | ||
| for relayuuid, robj := range relayList { | ||
| if now > robj.timeStamp && (now-robj.timeStamp) > int64(maxRelayIdle) { //5min max toleration |
There was a problem hiding this comment.
Looks like this is removed by mistake. @Omkar0114 Can you check and revert back change?
There was a problem hiding this comment.
Also check below errors:
Error: server/relaypeerservice.go:186:2: expected declaration, found s
Error: server/relaypeerservice.go:406:2: expected declaration, found s
Error: server/relaypeerservice.go:451:2: expected declaration, found ctx
Error: server/relaypeerservice.go:537:2: expected declaration, found ctx
There was a problem hiding this comment.
I make the change revert in server/relaypeerservice.go and few errors I saw in the local copy. Let's check now
Signed-off-by: Omkar <opkulkarni0104@gmail.com>
|
@Omkar0114 There are more go lint errors. Can you please take a look and fix them? |
|
Hey @Omkar0114 Did you get a chance to take a look? Need to fix CI failures. Also rebase your branch. |
|
Hey @Omkar0114 Checking if you're still working on this PR. |
|
Hey @akshay196 |
|
@Omkar0114 no worries. Unassigning issue so others can contribute. |
|
Closing because stale PR. |
What does this PR change?
Does the PR depend on any other PRs or Issues? If yes, please list them.
Checklist
I confirm, that I have...
CONTRIBUTING.mdgo fmt(if applicable)CHANGELOG.md