Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REST HTTP paths have collisions; some paths are not currently usable #313

Closed
dmihalcik-virtru opened this issue Mar 5, 2024 · 1 comment · Fixed by #824, #819 or #828
Closed

REST HTTP paths have collisions; some paths are not currently usable #313

dmihalcik-virtru opened this issue Mar 5, 2024 · 1 comment · Fixed by #824, #819 or #828
Assignees
@jakedoublev
Labels
bug Something isn't working comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry) needs triage

Comments

@dmihalcik-virtru
Copy link
Member

Our current use of gRPC Gateway with gorilla.mux results in several name collisions. Notably, the attributes/namespaces collides with the attributes/_ path.
@dmihalcik-virtru dmihalcik-virtru added the bug Something isn't working label Mar 5, 2024
@strantalis strantalis added the comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry) label Mar 5, 2024
@jakedoublev jakedoublev mentioned this issue May 16, 2024
Merged
@jakedoublev
Copy link
Contributor

All CRUD routes for Get, List, Update, Deactivate/Delete, Create were tested over RESTful gateway for the following policy:

  1. attribute namespaces
  2. attribute definitions
  3. attribute values
  4. subject condition sets
  5. subject mappings
  6. resource mappings

All were found to be accessible and working as expected, with the one exception being Update of resource mappings as POST instead of PATCH which PR #824 fixes.

github-merge-queue bot pushed a commit that referenced this issue May 16, 2024
@jakedoublev
fix(policy): make resource-mappings update patch instead of put in RE…
1878bb5 
…STful gateway (#824)

Closes #313
This was referenced May 15, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue May 20, 2024
@opentdf-automation
chore(main): release protocol/go 0.2.3 (#828)
59d9cc9 
🤖 I have created a release *beep* *boop*
---


##
[0.2.3](protocol/go/v0.2.2...protocol/go/v0.2.3)
(2024-05-17)


### Features

* **authz:** Handle jwts as entity chains in decision requests
([#759](#759))
([65612e0](65612e0))


### Bug Fixes

* **policy:** make resource-mappings update patch instead of put in
RESTful gateway ([#824](#824))
([1878bb5](1878bb5)),
closes [#313](#313)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this issue May 22, 2024
@opentdf-automation
chore(main): release service 0.4.3 (#819)
7cbe044 
🤖 I have created a release *beep* *boop*
---


##
[0.4.3](service/v0.4.2...service/v0.4.3)
(2024-05-22)


### Features

* **authz:** Allow un-scoped GetEntitlements calls
([#833](#833))
([9146947](9146947))
* **authz:** Handle jwts as entity chains in decision requests
([#759](#759))
([65612e0](65612e0))
* **ci:** Add e2e roundtrip tests for different attribute combinations
([#790](#790))
([1b0ec23](1b0ec23))
* **core:** Adds opentdf.hsm build constraint
([#830](#830))
([e13e52a](e13e52a))
* **core:** audit logging
([#774](#774))
([ea58b3c](ea58b3c))


### Bug Fixes

* **authz:** Populate fqn field in attribute values returned from
GetAttributeValuesByFqns
([#816](#816))
([0ac8390](0ac8390))
* **authz:** Typo in client secret config
([#835](#835))
([7cad1f1](7cad1f1))
* bump internal versions
([#840](#840))
([8f45f18](8f45f18))
* **core:** bump sdk deps to 0.2.3
([#848](#848))
([ca8b9f7](ca8b9f7))
* **policy:** fix policy fqn-reindex command schema suffix
([#818](#818))
([aff9850](aff9850)),
closes [#817](#817)
* **policy:** GetAttributeValuesByFqns and MatchSubjectMappings should
not return deactivated policy objects
([#813](#813))
([41ca82d](41ca82d)),
closes [#494](#494)
* **policy:** make resource-mappings update patch instead of put in
RESTful gateway ([#824](#824))
([1878bb5](1878bb5)),
closes [#313](#313)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
tech-guru42 added a commit to tech-guru42/TDF that referenced this issue Jun 3, 2024
@tech-guru42 @opentdf-automation
chore(main): release protocol/go 0.2.3 (#828)
fdc75a9 
🤖 I have created a release *beep* *boop*
---


##
[0.2.3](opentdf/platform@protocol/go/v0.2.2...protocol/go/v0.2.3)
(2024-05-17)


### Features

* **authz:** Handle jwts as entity chains in decision requests
([#759](opentdf/platform#759))
([65612e0](opentdf/platform@65612e0))


### Bug Fixes

* **policy:** make resource-mappings update patch instead of put in
RESTful gateway ([#824](opentdf/platform#824))
([1878bb5](opentdf/platform@1878bb5)),
closes [#313](opentdf/platform#313)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
tech-guru42 added a commit to tech-guru42/TDF that referenced this issue Jun 3, 2024
@tech-guru42 @opentdf-automation
chore(main): release service 0.4.3 (#819)
6db5f0f 
🤖 I have created a release *beep* *boop*
---


##
[0.4.3](opentdf/platform@service/v0.4.2...service/v0.4.3)
(2024-05-22)


### Features

* **authz:** Allow un-scoped GetEntitlements calls
([#833](opentdf/platform#833))
([9146947](opentdf/platform@9146947))
* **authz:** Handle jwts as entity chains in decision requests
([#759](opentdf/platform#759))
([65612e0](opentdf/platform@65612e0))
* **ci:** Add e2e roundtrip tests for different attribute combinations
([#790](opentdf/platform#790))
([1b0ec23](opentdf/platform@1b0ec23))
* **core:** Adds opentdf.hsm build constraint
([#830](opentdf/platform#830))
([e13e52a](opentdf/platform@e13e52a))
* **core:** audit logging
([#774](opentdf/platform#774))
([ea58b3c](opentdf/platform@ea58b3c))


### Bug Fixes

* **authz:** Populate fqn field in attribute values returned from
GetAttributeValuesByFqns
([#816](opentdf/platform#816))
([0ac8390](opentdf/platform@0ac8390))
* **authz:** Typo in client secret config
([#835](opentdf/platform#835))
([7cad1f1](opentdf/platform@7cad1f1))
* bump internal versions
([#840](opentdf/platform#840))
([8f45f18](opentdf/platform@8f45f18))
* **core:** bump sdk deps to 0.2.3
([#848](opentdf/platform#848))
([ca8b9f7](opentdf/platform@ca8b9f7))
* **policy:** fix policy fqn-reindex command schema suffix
([#818](opentdf/platform#818))
([aff9850](opentdf/platform@aff9850)),
closes [#817](opentdf/platform#817)
* **policy:** GetAttributeValuesByFqns and MatchSubjectMappings should
not return deactivated policy objects
([#813](opentdf/platform#813))
([41ca82d](opentdf/platform@41ca82d)),
closes [#494](opentdf/platform#494)
* **policy:** make resource-mappings update patch instead of put in
RESTful gateway ([#824](opentdf/platform#824))
([1878bb5](opentdf/platform@1878bb5)),
closes [#313](opentdf/platform#313)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
passion-127 added a commit to passion-127/TDF that referenced this issue Jun 6, 2024
@passion-127 @opentdf-automation
chore(main): release protocol/go 0.2.3 (#828)
8a0ebf9 
🤖 I have created a release *beep* *boop*
---


##
[0.2.3](opentdf/platform@protocol/go/v0.2.2...protocol/go/v0.2.3)
(2024-05-17)


### Features

* **authz:** Handle jwts as entity chains in decision requests
([#759](opentdf/platform#759))
([65612e0](opentdf/platform@65612e0))


### Bug Fixes

* **policy:** make resource-mappings update patch instead of put in
RESTful gateway ([#824](opentdf/platform#824))
([1878bb5](opentdf/platform@1878bb5)),
closes [#313](opentdf/platform#313)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
passion-127 added a commit to passion-127/TDF that referenced this issue Jun 6, 2024
@passion-127 @opentdf-automation
chore(main): release service 0.4.3 (#819)
7fc74f1 
🤖 I have created a release *beep* *boop*
---


##
[0.4.3](opentdf/platform@service/v0.4.2...service/v0.4.3)
(2024-05-22)


### Features

* **authz:** Allow un-scoped GetEntitlements calls
([#833](opentdf/platform#833))
([9146947](opentdf/platform@9146947))
* **authz:** Handle jwts as entity chains in decision requests
([#759](opentdf/platform#759))
([65612e0](opentdf/platform@65612e0))
* **ci:** Add e2e roundtrip tests for different attribute combinations
([#790](opentdf/platform#790))
([1b0ec23](opentdf/platform@1b0ec23))
* **core:** Adds opentdf.hsm build constraint
([#830](opentdf/platform#830))
([e13e52a](opentdf/platform@e13e52a))
* **core:** audit logging
([#774](opentdf/platform#774))
([ea58b3c](opentdf/platform@ea58b3c))


### Bug Fixes

* **authz:** Populate fqn field in attribute values returned from
GetAttributeValuesByFqns
([#816](opentdf/platform#816))
([0ac8390](opentdf/platform@0ac8390))
* **authz:** Typo in client secret config
([#835](opentdf/platform#835))
([7cad1f1](opentdf/platform@7cad1f1))
* bump internal versions
([#840](opentdf/platform#840))
([8f45f18](opentdf/platform@8f45f18))
* **core:** bump sdk deps to 0.2.3
([#848](opentdf/platform#848))
([ca8b9f7](opentdf/platform@ca8b9f7))
* **policy:** fix policy fqn-reindex command schema suffix
([#818](opentdf/platform#818))
([aff9850](opentdf/platform@aff9850)),
closes [#817](opentdf/platform#817)
* **policy:** GetAttributeValuesByFqns and MatchSubjectMappings should
not return deactivated policy objects
([#813](opentdf/platform#813))
([41ca82d](opentdf/platform@41ca82d)),
closes [#494](opentdf/platform#494)
* **policy:** make resource-mappings update patch instead of put in
RESTful gateway ([#824](opentdf/platform#824))
([1878bb5](opentdf/platform@1878bb5)),
closes [#313](opentdf/platform#313)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakedoublev jakedoublev

Labels
bug Something isn't working comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry) needs triage
Projects
None yet
Milestone
No milestone
3 participants
@strantalis @dmihalcik-virtru @jakedoublev