This is very useful if you're moving from a theme that supports feature image via URL.

Thanks @aakashnand I'll need some time to review this PR. My initial skim I would ask you to not do a style override in the single.html file. Either use the tailwind classes or create a new object in the main.css files that gets compiled into the final theme. Inline styling is really hard to manage. Also kudos on getting docs sorted already :)

Thanks @aakashnand I'll need some time to review this PR. My initial skim I would ask you to not do a style override in the single.html file. Either use the tailwind classes or create a new object in the main.css files that gets compiled into the final theme. Inline styling is really hard to manage. Also kudos on getting docs sorted already :)

@nunocoracao. Understood. I will update and see what can be done. I also forgot to add documentation about the new config that I introduced. .Params.maxWidth which allows customization from frontmatter.

@nunocoracao can you share any example of fetching frontmatter variables in CSS? I read many sites but I could not find how to access .Params.maxWidth in CSS.

What do I want to achieve?

Currently, the maxWidth responsible for markdown width is fixed at 65ch. See #834 and #847

.max-w-fit, .max-w-prose {
    max-width: {{.Params.maxWidth}}ch
}

this can be problematic when we enable a table of contents for the article. I wanted to add a front matter to be able to customize this width

@aakashnand please remove the extra parameter .Params.maxWidth from this PR. This is getting a little bloated and should be separate things. Also I don't think we should have that parameter in frontmatter

Yes will remove it soon. After going through the related issue. I think it's not necessary as I can override for my site.

@nunocoracao removed maxWidth. Let me know what do you think now.

@aakashnand I think it's just missing a check for whether the URL is defined in frontmatter before trying the getRemote calls. Also (and I didn't have time to check everything yet) I was not sure if the logic is the same for all? i.e. local image -> remote -> site default

@aakashnand I think it's just missing a check for whether the URL is defined in frontmatter before trying the getRemote calls. Also (and I didn't have time to check everything yet) I was not sure if the logic is the same for all? i.e. local image -> remote -> site default

Let me recheck. If you can point to specific line or file that would be super helpful

@nunocoracao

I made the changes you suggested.

1. Added a check to see if featureimage is present in the front matter before calling GetRemote
2. Also previously I forgot to add GetRemote for the author image. Now author image can be either present in the asset folder or can be set as an external URL as well.
3. Formatted code to enhance readability.
4. Added documentation for author.image saying that image can point to external URL now

sweet :) thanks a lot

@aakashnand I ended up making "some" changes e87e066

@nunocoracao Thank you so much for making the additional changes. I am glad I found this theme. I will soon send PR to add my site as a user