Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 The screen reader "skip to main content" flow skips too far down the page #1176

Open
meganlfox opened this issue Jan 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@meganlfox
Copy link

meganlfox commented Jan 17, 2024

Describe the bug
When you press the "skip to main content" button (with spacebar), the page scrolls past the main content, often substantially past.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any page in a site running Blowfish theme
  2. Press "tab" to select the "skip to main content" button (it must be the first thing you do upon loading the page since it relies on your tab stop being neutral)
  3. Press space bar to press the button
  4. The page will scroll substantially past the main content
  5. (though it functions as expected in mobile emulation mode)

Expected behavior
Upon pressing space to press the "skip to main content" button, the page should scroll down to the first textual or image content in the given page.

Screenshots
N/A

Desktop (please complete the following information):

  • Windows 10
  • Firefox
  • Version 121.0.1

Hugo & Blowfish versions
Hugo Version: 0.121.2
Blowfish Version: 2.50 (latest?)

Additional context
I think this specific change might be what broke this: https://github.com/nunocoracao/blowfish/pull/1120/files

The spacebar scrolling behavior is built into the browser, it's just that in this case, the button press should prevent the browser from also doing the scroll. So the scroll-past is the result of the "skip to main content" bumping you down to where it should, then the spacebar press ALSO scrolls you in and of itself, and the two combined shoot you way further down.

@nunocoracao nunocoracao changed the title The screen reader "skip to main content" flow skips too far down the page 馃悰 The screen reader "skip to main content" flow skips too far down the page Mar 9, 2024
@nunocoracao nunocoracao added the bug Something isn't working label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants