-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module Federation Dev server does not error out if a dev remote fails to start. #21393
Closed
1 of 4 tasks
Labels
Comments
AgentEnder
added
the
scope: module federation
Issues related to module federation support
label
Feb 2, 2024
Coly010
added a commit
that referenced
this issue
May 15, 2024
Coly010
added a commit
that referenced
this issue
May 15, 2024
jaysoo
pushed a commit
that referenced
this issue
May 21, 2024
…ccurs #21393 (#23400) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> `combineAsyncIterators` has a `finally` block which is blocking execution waiting for all iterators to be `done` so it can call the `return` function as cleanup. This leads to prolonged execution when unnecessary, such as when an error has occurred. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> `finally` block should be non-blocking allowing errors to be immediately surfaced and execution to stop. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #21393
FrozenPandaz
pushed a commit
that referenced
this issue
May 21, 2024
…ccurs #21393 (#23400) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> `combineAsyncIterators` has a `finally` block which is blocking execution waiting for all iterators to be `done` so it can call the `return` function as cleanup. This leads to prolonged execution when unnecessary, such as when an error has occurred. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> `finally` block should be non-blocking allowing errors to be immediately surfaced and execution to stop. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #21393 (cherry picked from commit 4442945)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Current Behavior
Module Federation Dev server does not error out if a dev remote fails to start.
Expected Behavior
Module Federation Dev server errors out if a dev remote fails to start.
GitHub Repo
No response
Steps to Reproduce
Nx Report
Failure Logs
No response
Package Manager Version
pnpm 8.14.3
Operating System
Additional Information
No response
The text was updated successfully, but these errors were encountered: