-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SensorType change in REST API breaks compatibility in 4.0.4 #2788
Comments
@wittypluck The fixes should work fine. But could you just give the |
Fixes work fine:
|
Great, thanks for the quick fix! |
The fix seemed to be included in the 4.0.5 release notes so I tested via my docker install of glances. Tag
Tag
|
Reproduced |
Idem with Glances 4.0.6/latest. |
Will be corrected in Glances 4.0.7 (build ongoing) |
I can confirm the issue is solved in |
Describe the bug
There is a Sensor type change in REST API in Glances v4.0.4 which breaks compatibility with previous versions.
I am not sure if this change is wanted, as it is not documented in the changes from v3 to v4 ?
This might be linked to this change which introduces a new SensorType Enum:
#2768
To Reproduce
Steps to reproduce the behavior:
curl http://localhost:61208/api/4/sensors
[{"label":"cpu_thermal 0","unit":"C","value":50,"warning":110,"critical":110,"type":"SensorType.CPU_TEMP","key":"label"}]
[{"label":"cpu_thermal 0","unit":"C","value":50,"warning":110,"critical":110,"type":"temperature_core","key":"label"}]
Expected behavior
THe API should probably return the same type as previous versions, or document the change.
Screenshots
If applicable, add screenshots to help explain your problem.
Environement (please complete the following information)
To be completed with result of: lsb_release -a
To be completed with result of: glances -V
docker
Additional context
Add any other context about the problem here.
You can also pastebin:
The text was updated successfully, but these errors were encountered: