Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: Add support for serving and including favicon #24

Open
mhthies opened this issue Dec 13, 2020 · 0 comments
Open

web: Add support for serving and including favicon #24

mhthies opened this issue Dec 13, 2020 · 0 comments
Labels
enhancement Improvement to an existing feature

Comments

@mhthies
Copy link
Owner

mhthies commented Dec 13, 2020

Should be implemented as an option for shc.web.interface.WebServer, taking a file path of the icon file.
@mhthies mhthies added the enhancement Improvement to an existing feature label Dec 13, 2020
mhthies added a commit that referenced this issue Dec 13, 2020
@mhthies
web: Add static favicon and apple-touch-icon
a776af8 
These icons have been designed by myself long ago for my previous smart
home web interface.

A quick fix for #24; however configurable icons as proposed in the issue
would still be nice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhthies