Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Implement sane MQTT defaults (PR already pending) #3813

Open
tropho23 opened this issue May 7, 2024 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@tropho23
Copy link
Contributor

tropho23 commented May 7, 2024

Platform

NRF52, ESP32

Description

Request making the default for MQTT to 'ignore MQTT' and maybe even set hop count for inbound MQTT packets to zero, if that is possible. The core issue here is people turning on MQTT, then either forgetting it's enabled or not caring about the impact it has to not only their local mesh but anyone connected to it via MQTT.

We need MQTT to be a tool for testing, a fun feature, and a nice capability to help join disparate meshes; right now without the proper attention and deliberate actions MQTT becomes a liability and burden for many users. Some boards still get overloaded and freeze/reset due to out of control traffic caused by mesh flooding by MQTT packets.

I think this might already be addressed by @GUVWAF's PR that is still pending review:
#3591

@tropho23 tropho23 added the enhancement New feature or request label May 7, 2024
@caveman99
Copy link
Sponsor Member

Whyile i agree with the reasoning behind this change, let's keep in mind the "MQTT Enabled" switch on a new firmware defaults to OFF. Anyone enabling this should know the side effects. We've had reports from Germany by people being confused about MQTT not working after they enabled it, because on duty cycle limited regions config.lora.ignore_mqtt defaults to OFF already.

@thebentern
Copy link
Contributor

Yes, this one is tricky because even in the US without the duty cycle default of off, we get a ton of support requests where users are confused by MQTT not working once enabled, not realizing the Channel up/downlink settings must be enabled first. Heck, it gets me sometimes

@GUVWAF
Copy link
Member

GUVWAF commented May 7, 2024

We've had reports from Germany by people being confused about MQTT not working after they enabled it, because on duty cycle limited regions config.lora.ignore_mqtt defaults to OFF already.

With my PR this actually is solved. Ignore MQTT will be on be default, but MQTT packets will be received if downlink enabled. Only when you disable "ignore MQTT" it will also rebroadcast it over LoRa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants