Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsanitized MQTT password #3806

Open
grizleeeee opened this issue May 6, 2024 · 2 comments
Open

Unsanitized MQTT password #3806

grizleeeee opened this issue May 6, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@grizleeeee
Copy link

Category

Other

Hardware

T-Lora v2 1.6, T-Deck, T-Echo, Rak4631, Heltec V3

Firmware Version

2.3.6, 2.3.7

Description

When using a password that only used pipes as separators, the entire MQTT settings page became unreadable to iOS clients, as well as sometimes the WebUI (not always reproducible, unclear what would cause this). Furthermore, the device was unable to utilize MQTT to connect. The settings were always visible from the command line, but inside the iOS app, the settings were unreadable and greyed out. The screen wouldn't even scroll. All other settings were accessible.

The obvious issues with the mobile/web client and it actually breaking the functionality were resolved immediately once the password was changed to something other than one that closely resembles a RegEx query.

Deprecated Password that caused the issue: CREED|hunter|AMPLE|outlet|STEED

Relevant log output

No response

@grizleeeee grizleeeee added the bug Something isn't working label May 6, 2024
@garthvh
Copy link
Member

garthvh commented May 6, 2024

iOS could care less about pipes so not sure that is the actual issue, oddly it will save CREED|hunter|AMPLE|outlet|STEE

@grizleeeee
Copy link
Author

So the password would save when set from the CLI, but then the MQTT settings page in the iOS client would be unreadable and completely greyed out. I've attached an example of the settings being inaccessible, and it appears to be isolated to the MQTT pane. https://github.com/meshtastic/firmware/assets/2353329/1b45c0f6-a6d3-42d6-8b1d-0c23e3ef0773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants