Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounded Line generates warning, displays incorrectly #1102

Open
PinkMushroom opened this issue Apr 23, 2024 · 2 comments
Open

Rounded Line generates warning, displays incorrectly #1102

PinkMushroom opened this issue Apr 23, 2024 · 2 comments

Comments

@PinkMushroom
Copy link

PinkMushroom commented Apr 23, 2024

python3.10/site-packages/vedo/shapes.py:971: RuntimeWarning: invalid value encountered in arccos

Screenshot from 2024-04-22 19-15-03

In the image , the RoundedLine is on the left and a Line is on the right.

I will look closely at the data and see if I can figure out why it may be doing this.


Caught it in the act:

u [116.42391429 0. 0. ] v [240.26706128 0. 0. ]
np.dot(u,v) 27972.831748915956 du 116.42391428905057 dv 240.2670612797524
np.dot(u,v)/du/dv 1.0000000000000002

Because the argument is > 1.0 np.arccos returns a 'nan' causing the rounded line to be drawn incorrectly.

@PinkMushroom PinkMushroom changed the title Rounded Line generates warning displays incorrectly Rounded Line generates warning, displays incorrectly Apr 23, 2024
@marcomusy
Copy link
Owner

Thanks @PinkMushroom feel free to make PR to fix the issue the way you think it's best!

@PinkMushroom
Copy link
Author

Done. @marcomusy . I sure hope it worked.
I'm a noobie when it comes to making PRs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants