Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No favicon loaded if no favicon.svg exists #897

Open
dani0854 opened this issue Mar 2, 2024 · 0 comments
Open

No favicon loaded if no favicon.svg exists #897

dani0854 opened this issue Mar 2, 2024 · 0 comments

Comments

@dani0854
Copy link

dani0854 commented Mar 2, 2024

Describe the problem:

According to:
https://github.com/luizdepra/hugo-coder/blob/745f785dd9a76b5102e6e58c9e5e550c458a6273/layouts/partials/head/custom-icons.html

All the icons are specified, no matter if they are configured or not.
In my case I don't have favicon.svg, since I only have rasterized images, and turning them into vector images is painful. I only specified favicon{16x16,32x32}.ico.

But since the resulting HTML has all of them specified with default paths for ones I didn't specify.
It looks like browser (I am using Firefox) is choosing to only load favicon.svg which I don't have, and it results in the page opening without favicon.

On other pages though Firefox has no problem loading favicon{16x16,32x32}.ico.

I am not an expert in web development. But I assume there should be a way to disable certain favicons if they are not used, so they don't appear in resulting HTML files.

Steps to reproduce:

  1. Specify paths in config for only favicon{16x16,32x32}.ico
  2. Open the page with Firefox

Observed Results:

  • What did happen: Favicon not there. And two 404 in network monitor for favicon.svg and apple_touch_icon.png
  • What did you expect to happen: Favicon is present, and no 404 in network monitor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant