Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop inbound provider records when overloaded #675

Open
Stebalien opened this issue Jun 19, 2020 · 0 comments · May be fixed by #730
Open

Drop inbound provider records when overloaded #675

Stebalien opened this issue Jun 19, 2020 · 0 comments · May be fixed by #730
Labels
kind/enhancement A net-new feature or improvement to an existing feature research

Comments

@Stebalien
Copy link
Member

  1. We should drop inbound provider records when overloaded, and return an error to the sender. Otherwise, we can build up a backlog of provider records.
  2. If we do this frequently, we should switch from server mode to client mode as our disk probably isn't fast enough to keep up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature research
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Degrade provider handling quality gracefully under load libp2p/go-libp2p-kad-dht
2 participants
@Stebalien @jacobheun