You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
From D/P/Pt to US/UM, the gender symbols that can be entered in Korean games are the halfwidth glyphs (0x01BB0x01BC in Gen4, \u246D\u246E in Gen5, \uE08E\uE08F in Gen 6/7), not the fullwidth glyphs used in Japanese/Chinese games (0x00EE0x00EF in Gen4, ♀♂ in Gen 5/6/7). Currently, the UnSanitizeChar methods do not properly handle this.
For Nidoran♀ and Nidoran♂, their Korean species names use the fullwidth glyphs in D/P/Pt and the halfwidth glyphs from HG/SS onward. The fullwidth glyphs are preserved when transferred to Gen5. I'm not able to test this myself, but the VC Korean Gen2 table appears to use the fullwidth glyphs, so an unnicknamed Nidoran transferred from Korean G/S might have its name treated as a nickname. Gen5->Transporter and Bank->HOME should reset their species names for unnicknamed Pokémon.
Relatedly, the editor incorrectly uses the halfwidth forms in Japanese for Gen4/5.
To Reproduce
Example 1:
Hatch an unnicknamed Nidoran in a Korean Gen6/7 game
View the Nidoran and use "Save PKM..."
Open both files in a hex editor
The saved PKM will incorrectly have fullwidth forms (U+2642/0)
Example 2:
Hatch an unnicknamed Nidoran in Korean D/P/Pt
Transfer to Korean Gen5
View the Nidoran and use "Save PKM..."
Open both files in a hex editor
The saved PKM will incorrectly have halfwidth forms (U+246D/E)
Example 3:
Nickname a Pokémon using gender symbols in Japanese Gen4/5
View the Pokémon and use "Save PKM..."
Open both files in a hex editor
The saved PKM will incorrectly have halfwidth forms
Expected behavior
These can be verified by using drag-and-drop to save the Pokémon directly to a file, without going through the editor.
The saved PKM should have halfwidth forms (U+E08E/F)
The saved PKM should have fullwidth forms (U+2642/0)
The saved PKM should have fullwidth forms
Additional context GetIsFullWidthString doesn't appear to be used for Gen4/5 unsanitization. These halfwidth characters can be entered in Gen4-7 that aren't in the U+0000-0FFF or U+E000-EFFF ranges: ‘, ’, “, ”, „, and ・ (beside the Korean characters). For the edge case where the nickname/OT is a single ♀♂ glyph, it could be recognized as halfwidth even when the OT/nickname is unambiguously fullwidth, which wouldn't normally be possible.
The text was updated successfully, but these errors were encountered:
Looks like there are additional revisions for 7->8+ where symbols are migrated from the private section (0xE08x) back to the fullwidth section (0x24xx), and some that just get skipped (shortening the string). Maybe next time :P
Describe the bug
From D/P/Pt to US/UM, the gender symbols that can be entered in Korean games are the halfwidth glyphs (
0x01BB
0x01BC
in Gen4,\u246D
\u246E
in Gen5,\uE08E
\uE08F
in Gen 6/7), not the fullwidth glyphs used in Japanese/Chinese games (0x00EE
0x00EF
in Gen4,♀
♂
in Gen 5/6/7). Currently, theUnSanitizeChar
methods do not properly handle this.For Nidoran♀ and Nidoran♂, their Korean species names use the fullwidth glyphs in D/P/Pt and the halfwidth glyphs from HG/SS onward. The fullwidth glyphs are preserved when transferred to Gen5. I'm not able to test this myself, but the VC Korean Gen2 table appears to use the fullwidth glyphs, so an unnicknamed Nidoran transferred from Korean G/S might have its name treated as a nickname. Gen5->Transporter and Bank->HOME should reset their species names for unnicknamed Pokémon.
Relatedly, the editor incorrectly uses the halfwidth forms in Japanese for Gen4/5.
To Reproduce
Example 1:
Example 2:
Example 3:
Expected behavior
These can be verified by using drag-and-drop to save the Pokémon directly to a file, without going through the editor.
Additional context
GetIsFullWidthString
doesn't appear to be used for Gen4/5 unsanitization. These halfwidth characters can be entered in Gen4-7 that aren't in the U+0000-0FFF or U+E000-EFFF ranges:‘
,’
,“
,”
,„
, and・
(beside the Korean characters). For the edge case where the nickname/OT is a single♀
♂
glyph, it could be recognized as halfwidth even when the OT/nickname is unambiguously fullwidth, which wouldn't normally be possible.The text was updated successfully, but these errors were encountered: