Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use kubebuilder CEL support for validation #9999

Open
lahabana opened this issue Apr 19, 2024 · 1 comment
Open

Use kubebuilder CEL support for validation #9999

lahabana opened this issue Apr 19, 2024 · 1 comment
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

Description

Kubebuilder can use CEL for validation with: // +kubebuilder:validation:XValidation

Example usage: https://github.com/Kong/kubernetes-ingress-controller/blob/1fc18b896dd6022755741fd1ba9200b6b0b36ab5/pkg/apis/configuration/v1/kongplugin_types.go#L36-L38

ref: https://book.kubebuilder.io/reference/markers/crd-validation

It would be good for us because that'd move the validation at the validation webhook and it wouldn't be hard to have this stuff for universal too.
@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Apr 19, 2024
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it kind/improvement Improvement on an existing feature and removed triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Apr 22, 2024
@jakubdyszkiewicz
Copy link
Contributor

Triage: let's do PoC first of the most complex object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lahabana @jakubdyszkiewicz