Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategy on sync name conflict #10212

Open
jakubdyszkiewicz opened this issue May 10, 2024 · 3 comments
Open

Strategy on sync name conflict #10212

jakubdyszkiewicz opened this issue May 10, 2024 · 3 comments
Assignees
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@jakubdyszkiewicz
Copy link
Contributor

Description

When we apply policies on global and zone, we hash them so it's very unlikely that we get into name conflicts. However, it's still possible with the following steps

  1. Apply object on global named xyz, see that synced name in zone is xyz-hashname
  2. I delete object on global
  3. I apply object on zone with name xyz-hashname. It’s synced to global but that does not matter here
  4. I apply the same object on global named xyz

Let see what happens. We need to have a defined strategy for such case.

@jakubdyszkiewicz jakubdyszkiewicz added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature triage/needs-reproducing Someone else should try to reproduce this and removed triage/pending This issue will be looked at on the next triage meeting labels May 10, 2024
@jakubdyszkiewicz
Copy link
Contributor Author

Triage: needs-reproducing to figure out what happens now

@Automaat
Copy link
Contributor

Automaat commented May 17, 2024

Applying steps from issue description ends with error on zone:

2024-05-17T08:28:55.172Z    INFO    kds-delta-zone    creating a new resource from upstream    {"type": "MeshTimeout", "name": "mesh-timeout-all-default-bv8z44b7bzb99xc7.kong-mesh-system", "mesh": "default"}
2024-05-17T08:28:55.292Z    INFO    kds-delta-zone    error during callback received, sending NACK    {"kds-version": "v2", "err": "resource already exists: type=\"MeshTimeout\" name=\"mesh-timeout-all-default-bv8z44b7bzb99xc7.kong-mesh-system\" mesh=\"default\""}

It would be nice to add status to policy with this error on global

@Automaat Automaat added triage/pending This issue will be looked at on the next triage meeting and removed triage/needs-reproducing Someone else should try to reproduce this labels May 17, 2024
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels May 20, 2024
@jakubdyszkiewicz
Copy link
Contributor Author

Triage: rejection is fine. It would be great to bubble up this error better than logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

2 participants