Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert all "date-like" data from strings into JS Dates in the data layer #2206

Open
johncowen opened this issue Feb 20, 2024 · 1 comment
Open

convert all "date-like" data from strings into JS Dates in the data layer #2206

johncowen opened this issue Feb 20, 2024 · 1 comment
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@johncowen
Copy link
Contributor

Description

We currently parse these using Date.parse in the view/*View.vue files, but we should convert these strings to actual date in our data layer instead.

Also see #2117

  • Use common.formats.datetime instead of formatIsoDate. I've not data converted all our 'string-dates' to actual dates yet, but I'll probably do that in a follow up.
@johncowen johncowen added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Feb 20, 2024
@johncowen johncowen changed the title convert all date type data from strings to JS Dates in the data layer convert all date type data from strings into JS Dates in the data layer Feb 20, 2024
@johncowen johncowen changed the title convert all date type data from strings into JS Dates in the data layer convert all "date-like" data from strings into JS Dates in the data layer Feb 20, 2024
@jakubdyszkiewicz jakubdyszkiewicz added kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it and removed kind/feature New feature triage/pending This issue will be looked at on the next triage meeting labels Feb 26, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johncowen @jakubdyszkiewicz @lukidzi