Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve zone inspect view #2164

Open
lahabana opened this issue Feb 9, 2024 · 2 comments
Open

Improve zone inspect view #2164

lahabana opened this issue Feb 9, 2024 · 2 comments
Assignees
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone

Comments

@lahabana
Copy link
Contributor

lahabana commented Feb 9, 2024

Description

  1. Since 2.6.0 there's a zoneInstanceId field which is more useful to users that the globalInstanceId.

See:

 "zoneInsight": {
  "subscriptions": [
   {
    "id": "792e2051-4f0c-4df6-ab03-1701b2b8af99",
    "globalInstanceId": "mink-control-plane-5c98999c7c-wsc2t-875e",
    "connectTime": "2024-02-06T12:38:04.230480952Z",
    "disconnectTime": "2024-02-06T16:14:13.958395810Z",
    "status": {
     "lastUpdateTime": "2024-02-06T15:14:54.374063306Z",
     "total": {
      "responsesSent": "45",
      "responsesAcknowledged": "45"
     }
    },
    "version": {
     "kumaCp": {
      "version": "2.6.0",
      "gitTag": "2.6.0",
      "gitCommit": "53744108710a5151b4b8121f7b9392ffc0f3651c",
      "buildDate": "2024-02-01T13:41:52Z",
      "kumaCpGlobalCompatible": true
     }
    },
    "generation": 86,
    "authTokenProvided": true,
    "zoneInstanceId": "kong-mesh-control-plane-84ccc98fc4-6zzzv-feca"
   },...

We should show this instead of the Global InstanceId as this is more useful
image

  1. We should also show: the version at the top. Finally each subscription should have a copy raw button to just get the json/yaml of the subscription. We should also show if the version is not the latest to suggest upgrade to customers.
  2. We should make it obvious when the zone is returning NACKs (I think we may need a backend change to be able to do this).
@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Feb 9, 2024
@lahabana lahabana added this to the 2.7.x milestone Feb 9, 2024
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it kind/improvement Improvement on an existing feature and removed triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Feb 12, 2024
@lahabana lahabana modified the milestones: 2.7.x, 2.8.x Mar 25, 2024
@johncowen johncowen self-assigned this May 22, 2024
@johncowen
Copy link
Contributor

Still to do:

  • Finally each subscription should have a copy raw button to just get the json/yaml of the subscription.
  • We should also show if the version is not the latest to suggest upgrade to customers.
  • We should make it obvious when the zone is returning NACKs (I think we may need a backend change to be able to do this).

@lahabana
Copy link
Contributor Author

Let's also put the last connected subscription's version in the top bar and then do change the colour if it doesn't match the global cp version (with a tooltip to indicate version is different). If very is not an exact semver (.e.g: 0.0.0-preview.vdeadbeef) don't change the colour (I think it's more or less if not match [0-9]+\.[0-9]+\.[0-9]+).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

3 participants