Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler_perf: define thresholds per test case and set up alerts for results #124774

Open
sanposhiho opened this issue May 9, 2024 · 7 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.

Comments

@sanposhiho
Copy link
Member

sanposhiho commented May 9, 2024

/kind feature
/sig scheduling

Discussion with sig-scalability: https://kubernetes.slack.com/archives/C09QZTRH7/p1715262959575039

What

We have scheduler-perf, and it'd be great if we could have an alert-ish stuff based on the result.

Based on the discussion with sig-scalability, the easiest way is to change scheduler_perf so that it can fail if the results show degradation, and monitor/alert the failures via testgrid.

"if the results show degradation" > for this, we probably have to define reasonable thresholds per test case.

Why

The current pain point is that perf-dash visualizes it, but no one actually doesn't care much, and consequently we've overlooked degradation several times actually.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 9, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sanposhiho
Copy link
Member Author

@kubernetes/sig-scheduling-misc any feedback for the direction proposed above?

@alculquicondor
Copy link
Member

+1 from me.

Also, the dashboard doesn't load for me (unless the link is wrong?)

@alculquicondor
Copy link
Member

Nvm, it loads :)

@sanposhiho
Copy link
Member Author

/assign

I just assigned it to me so that it remains on my todo list, but it might take some time for me to come back here because of other prioritized tickets. So, if anyone wants, feel free to take over (I can help reviews either way).

@utam0k
Copy link
Member

utam0k commented May 12, 2024

Can I help you?

@sanposhiho
Copy link
Member Author

Yes,
/assign @utam0k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Development

No branches or pull requests

4 participants