Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support env variables in values from envFrom #124756

Open
lesaux opened this issue May 8, 2024 · 2 comments
Open

Support env variables in values from envFrom #124756

lesaux opened this issue May 8, 2024 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@lesaux
Copy link

lesaux commented May 8, 2024

What would you like to be added?

Currently if I define environment variables on container in the following way:

env:
  - name: SOME_VAR
     value: SOME_VALUE
  - name: SOME_OTHER_VAR
     value: SOME_OTHER_VALUE-$(SOME_VALUE)
envFrom:
  - secretRef:
      name: some-secret

When one of the values in the secret being set to $(SOME_VAR), that value doesn't get replaced.

SOME_OTHER_VAR gets replaced properly, but the envFrom, wether its a configmap or secret doesn't get replaced.

Why is this needed?

It would be quite nice to simplify very long manifests by removing most env: stanzas in favor of envFrom:

@lesaux lesaux added the kind/feature Categorizes issue or PR as related to a new feature. label May 8, 2024
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 8, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 8, 2024
@HirazawaUi
Copy link
Contributor

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests

3 participants