Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change EvaluatedNodes to count Nodes that reach Filter phase only #124705

Closed
sanposhiho opened this issue May 6, 2024 · 3 comments · Fixed by #124735
Closed

Change EvaluatedNodes to count Nodes that reach Filter phase only #124705

sanposhiho opened this issue May 6, 2024 · 3 comments · Fixed by #124735
Assignees
@AxeZhan
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.

Comments

@sanposhiho
Copy link
Member

sanposhiho commented May 6, 2024 •
edited

Currently, EvaluatedNodes contains the number of nodes that filtered out by PreFilterResult and Filter plugins.
But, before #119779, actually it only contains Nodes reach Filter plugins, which is actually more useful than the current state.

This issue aims to bring back the previous EvaluatedNodes.

ref: #119779 (comment)
/cc @alculquicondor
/sig scheduling
/kind feature
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. kind/feature Categorizes issue or PR as related to a new feature. labels May 6, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 6, 2024
@sanposhiho sanposhiho changed the title Change EvaluatedNodes to count Nodes that go through PreFilter only Change EvaluatedNodes to count Nodes that reach Filter phase only May 6, 2024
@sanposhiho sanposhiho mentioned this issue May 6, 2024
Merged
@AxeZhan
Copy link
Member

AxeZhan commented May 6, 2024

/assign
I'll take a look recently

@alculquicondor
Copy link
Member

FYI #124709

@alculquicondor alculquicondor mentioned this issue May 6, 2024
Closed
@AxeZhan AxeZhan mentioned this issue May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AxeZhan AxeZhan

Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change EvaluatedNodes to count Nodes that reach Filter phase only AxeZhan/kubernetes
4 participants
@alculquicondor @k8s-ci-robot @sanposhiho @AxeZhan