Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop archived vendored libraries and switch to active ones #124695

Open
5 tasks
dims opened this issue May 4, 2024 · 6 comments
Open
5 tasks

Drop archived vendored libraries and switch to active ones #124695

dims opened this issue May 4, 2024 · 6 comments
Labels
area/code-organization Issues or PRs related to kubernetes code organization needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.

Comments

@dims
Copy link
Member

dims commented May 4, 2024

Follow up to #120276

@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 4, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dims
Copy link
Member Author

dims commented May 4, 2024

"github.com/grpc-ecosystem/go-grpc-prometheus" is only from etcd.

Search query: https://cs.k8s.io/?q=github.com%2Fgrpc-ecosystem%2Fgo-grpc-prometheus&i=nope&files=%5C.go&excludeFiles=&repos=kubernetes/kubernetes

issue already filed xref - etcd-io/etcd#17883

@dims
Copy link
Member Author

dims commented May 4, 2024

"github.com/pkg/errors" is there in our code, so we should deal with it first. There are lots of hits in kubeadm ( cc @pacoxu and @neolit123 )

https://cs.k8s.io/?q=%22github.com%2Fpkg%2Ferrors&i=nope&files=%5C.go&excludeFiles=vendor&repos=kubernetes/kubernetes

@dims
Copy link
Member Author

dims commented May 5, 2024

shlex seems to be only from kustomize:

❯ rg "google/shlex" | grep "\.go"
vendor/sigs.k8s.io/kustomize/api/internal/plugins/execplugin/execplugin.go:	"github.com/google/shlex"

@neolit123
Copy link
Member

"github.com/pkg/errors" is there in our code, so we should deal with it first. There are lots of hits in kubeadm ( cc @pacoxu and @neolit123 )

https://cs.k8s.io/?q=%22github.com%2Fpkg%2Ferrors&i=nope&files=%5C.go&excludeFiles=vendor&repos=kubernetes/kubernetes

yeah, this was discussed before. the repo is unmaintained but it's not insecure. if we can continue using - great. if we cannot, we are going to fork it under cmd/kubeadm.

we need that stack tracing, consistent wrapping and error formating. just fmt.Error with %w is not a replacement.

@neolit123
Copy link
Member

/sig architecture
/area code-organization

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. area/code-organization Issues or PRs related to kubernetes code organization and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code-organization Issues or PRs related to kubernetes code organization needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.
Projects
None yet
Development

No branches or pull requests

3 participants