Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GHC 9.0 in generated projects #539

Closed
vrom911 opened this issue Mar 9, 2021 · 2 comments · Fixed by #556
Closed

Support GHC 9.0 in generated projects #539

vrom911 opened this issue Mar 9, 2021 · 2 comments · Fixed by #556
Assignees
@chshersh @vrom911
Labels
generated project Files, folder generation by the summoner ghc Add/remove GHC versions, options
Milestone
v2.1: Modernize &...

Comments

@vrom911
Copy link
Member

vrom911 commented Mar 9, 2021

No description provided.

@vrom911 vrom911 added generated project Files, folder generation by the summoner ghc Add/remove GHC versions, options labels Mar 9, 2021
@chshersh chshersh added this to the v2.1: Update milestone Mar 9, 2021
@ArturGajowy
Copy link

Is there anything that prevents resolving the available GHC versions dynamically? Say, from ghcup, stack lts, or even adding the one available on PATH? I've seen there's support for 8.10 implemented, but I didn't get it from a fresh cabal install (v2.1 is not released yet?).

Additionally you can specify versions of GHC to test with (space-separated): 
  ⓘ Supported by 'summoner' GHCs: 7.10.3 8.0.2 8.2.2 8.4.4 8.6.5 8.8.3
 ** SNIP **

Job's done
✔ ~/projects 
14:50 $ ghc --version
The Glorious Glasgow Haskell Compilation System, version 8.10.4
✔ ~/projects 
14:50 $ summon --version
Summoner v2.0.1.1
 ➤ Git revision: UNKNOWN
 ➤ Commit date:  UNKNOWN

@chshersh
Copy link
Contributor

chshersh commented Aug 3, 2021

@ArturGajowy I wrote a comment previously, providing an explanation of why config-based approach will result in bad UX. The same is true for the dynamic discovery of GHC.

Yes, 2.1 is not on Hackage yet. If you want to use the latest Summoner version, you can install it from sources.

@chshersh chshersh pinned this issue Sep 18, 2021
vrom911 added a commit that referenced this issue Jan 11, 2022
@vrom911
[#539] Support GHC 9.0 in generated projects
34e52b0 
Resolves #539
@vrom911 vrom911 mentioned this issue Jan 11, 2022
Merged
vrom911 added a commit that referenced this issue Jan 11, 2022
@vrom911
[#539] Support GHC 9.0 in generated projects
d12098d 
Resolves #539
chshersh added a commit that referenced this issue Jan 11, 2022
@vrom911 @chshersh
[#539] Support GHC 9.0 in generated projects (#556)
0c03dd0 
* [#539] Support GHC 9.0 in generated projects

Resolves #539

* Update CHANGELOG

* Fix ci setup for 9.0.2

* Apply suggestions from code review

Co-authored-by: Dmitrii Kovanikov <kovanikov@gmail.com>

* Update lts version for 8.10

* Fix

* Fix stack build

Co-authored-by: Dmitrii Kovanikov <kovanikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chshersh chshersh

@vrom911 vrom911

Labels
generated project Files, folder generation by the summoner ghc Add/remove GHC versions, options
Projects
None yet
Milestone
v2.1: Modernize & Resurrect
Development

Successfully merging a pull request may close this issue.

[#539] Support GHC 9.0 in generated projects kowainik/summoner
3 participants
@ArturGajowy @chshersh @vrom911