Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic helm chart as source of the provided yamls #1269

Closed
micw opened this issue Apr 21, 2024 · 2 comments
Closed

Basic helm chart as source of the provided yamls #1269

micw opened this issue Apr 21, 2024 · 2 comments

Comments

@micw
Copy link
Contributor

micw commented Apr 21, 2024

Hello,

I have seen that there are multiple attempts to create (and maintain) a helm chart for multus. Unfortunately, all of them seems to be outdated (maybe except the bitname one but this seems to be very customized and dot following the current example yamls in this project).

What do you think about a basic helm chart that is part of this project and contains just the stuff that is currently in the examples in "deployments"? So instead of maintaining the yaml examples, this project could maitain the helm chart. The examples then can simply be generated out of the helm chart. This way, there's no additional maintenance overhead but there would be an "official" helm chart.

If you're open to this, I'd create a PR for a initial chart, containing what's already in the example yamls.

Kind regards,
Michael.

@micw
Copy link
Contributor Author

micw commented Apr 21, 2024

To show what I mean, I have started with an initial helm chart and a script that generates the content of multus-daemonset.yml: https://github.com/micw/multus-cni/tree/feature/helm-chart/deployments

Please let me know what you think.

@dougbtv
Copy link
Member

dougbtv commented May 23, 2024

@micw we'd love your contributions against the helm charts -- it's one of those places where there's always more contributions necessary, you can find the charts @ https://github.com/k8snetworkplumbingwg/helm-charts

And if you would like to interact with us about the changes, feel free to join our maintainer calls, connection info @ https://github.com/k8snetworkplumbingwg/community

@dougbtv dougbtv closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants