update deploy file: use install_multus bin to update cni file #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1061123
requested changes
Feb 15, 2024
There was a problem hiding this comment.
Hi @41tair, thank you for the PR!
Once we use install_multus for thick pluigin, then we could change container base image to distroless from
multus-cni/images/Dockerfile.thick
Line 10 in ba18cf5
to such like that as thin Dockerfile
Line 11 in ba18cf5
Could you pelase take care of that?
|
Anything left to do on this? Think mode seems broken/risky without it. |
|
Reluctant to deploy a new instance of multus until this bug is fixed. |
Would love to see this fixed. |
kfox1111
reviewed
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install cni initcontiainer can't execute sometimes
a sample error logs looks like:
cp: cannot create regular file '/host/opt/cni/bin/multus-shim': Text file busy
Fixes #1221