Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favicon.ico in Params #319

Open
yshym opened this issue Aug 18, 2020 · 2 comments
Open

favicon.ico in Params #319

yshym opened this issue Aug 18, 2020 · 2 comments

Comments

@yshym
Copy link

yshym commented Aug 18, 2020

Why is favicon.ico passed to Params if your url template is f.e. /:id?

@yshym yshym closed this as completed Aug 18, 2020
@yshym yshym reopened this Aug 18, 2020
@gunawanwijaya
Copy link

because * and :arg is a wildcard-like pattern; but instead assigned the value in arg;
maybe you need to consider the pattern? like /user/:id?
when no favicon registered in html, browser will automatically get from /favicon.ico
so yeah, you get 2 incoming connection from browser the actual path + favicon path

@yshym
Copy link
Author

yshym commented Oct 12, 2020

I think, favicon.ico should be ignored if the path is /:id. I leave this issue opened. In the case it is not a bug any maintainer can close this thread

similark pushed a commit to similarweb/httprouter that referenced this issue May 9, 2023
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants