Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish language detection does not work properly on Google Chrome. #14764

Open
2 of 11 tasks
Maniues opened this issue May 20, 2024 · 13 comments
Open
2 of 11 tasks

Polish language detection does not work properly on Google Chrome. #14764

Maniues opened this issue May 20, 2024 · 13 comments

Comments

@Maniues
Copy link

Maniues commented May 20, 2024

What happened?

Jitsi Meet does not detect Polish language encoded in navigator.language as pl-PL and sets English language.

On Firefox or MS Edge, Polish is encoded as pl and Jitsi Meet's language detection properly works with these browsers.

Platform

  • Chrome (or Chromium based)
  • Firefox
  • Safari
  • Other desktop browser
  • Android browser
  • iOS browser
  • Electron app
  • Android mobile app
  • iOS mobile app
  • Custom app using a mobile SDK

Browser / app / sdk version

Chrome 124.0.6367.208 / 125.0.6422.61 (tested on both)

Relevant log output

No response

Reproducibility

  • The problem is reproducible on meet.jit.si

More details?

Tested on meet.jit.si and on internal deployment.

@damencho
Copy link
Member

Have you tried in incognito?

@Maniues
Copy link
Author

Maniues commented May 20, 2024

Yes, I did

@Maniues
Copy link
Author

Maniues commented May 20, 2024

I checked, and it turned out that the problem occurs in incognito mode, but not necessarily in other modes.

I still find this a problem because in incognito mode the language value is pl-PL and our deployment is meant to use Polish language in this case.

@damencho
Copy link
Member

What are the values of navigator.languages, navigator.userLanguage and navigator.language in the browsers it work and in the browsers it does not work?

@Maniues
Copy link
Author

Maniues commented May 20, 2024

For browser with incorrect language:
navigator.languages: ['pl-PL']
navigator.userLanguage: undefined
navigator.language: 'pl-PL'

For browser with correct language:
navigator.languages: ['pl-PL', 'pl', 'en-US', 'en']
navigator.userLanguage: undefined
navigator.language: 'pl-PL'

@saghul
Copy link
Member

saghul commented May 21, 2024

@damencho IIRC there was a similar report for Spanish, being es-ES.

@damencho
Copy link
Member

Yeah. And a PR will look at it when I find some time

@saghul
Copy link
Member

saghul commented May 21, 2024

Excellent, thanks!

@damencho
Copy link
Member

@Maniues How did you change the language in chrome? If I go and change it via settings :
image

I get:
navigator.language: 'pl'

I wonder how do you get the pl-PL setting?

@Maniues
Copy link
Author

Maniues commented May 24, 2024

I don't change my language, since I'm Polish.
Please note that it only occurs in incognito mode.

I'll check this and let you know what settings I'm chrome return pl-PL l.

@Maniues
Copy link
Author

Maniues commented Jun 10, 2024

I don't have any specific settings. This parameter may be controlled by Chrome 's default installer and the user's system location.

@saghul
Copy link
Member

saghul commented Jun 10, 2024

Does it happen in normal mode? What value do you get for the language in that case?

@Maniues
Copy link
Author

Maniues commented Jun 10, 2024

For browser with incorrect language:
navigator.languages: ['pl-PL']
navigator.userLanguage: undefined
navigator.language: 'pl-PL'

For browser with correct language:
navigator.languages: ['pl-PL', 'pl', 'en-US', 'en']
navigator.userLanguage: undefined
navigator.language: 'pl-PL'

These are all values I got.
Browser with correct language = normal mode, incorrect = incognito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants