-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email Styling and Redirection Issues in Gmail #9564
Comments
Thanks, the double |
Probably something as easy as changing the following code block: immich/server/src/services/notification.service.ts Lines 49 to 58 in 6b369e8
const { server } = await this.configCore.getConfig();
const baseUrl = () => {
let url = 'http://localhost:2283';
try {
var url = (new URL(server.externalDomain)).origin;
} catch (e) {}
return url;
}
const { html, text } = this.notificationRepository.renderEmail({
template: EmailTemplate.WELCOME,
data: {
baseUrl: url,
displayName: user.name,
username: user.email,
password: tempPassword,
},
}); (if you don't care about IE you can remove the Ideally this should be earlier on, especially if server.externalDomain is used elsewhere, but this should work. |
Let's instead normalize it in getConfig instead. |
The bug
I have configured a mail server with Google. However, I have two issues:
I see in the code that the base URL is concatenated with
/auth/login
. In my case, the base URLhttps://xxx/
combined with/auth/login
results in the double slashes (https://xxx//auth/login
).Also, I am using Nginx with Nginx Proxy Manager. Could this be causing the ending / in my base URL?
The OS that Immich Server is running on
TrueNAS-SCALE-23.10.2
Version of Immich Server
v1.105.1
Version of Immich Mobile App
v1.105.1
Platform with the issue
Your docker-compose.yml content
Running on TrueNAS
Your .env content
Reproduction steps
Relevant log output
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: