Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra_latex_after= argument to add_header_above() --- Happy to implement. #828

Open
krivit opened this issue Mar 6, 2024 · 3 comments

Comments

@krivit
Copy link

krivit commented Mar 6, 2024

This is to parallel the eponymous argument to row_spec(). I have a preliminary implementation and would be happy to submit a PR.

To Reproduce

---
output: pdf_document
---

```{r}
library(kableExtra)
data(mtcars)
mtcars <- mtcars[1:3, 1:3]
```
```{r}
kable(mtcars) |>
  add_header_above(c("abc"=2, "def"=2), extra_latex_after = "\\cline{3-4}", line=FALSE)
```

produces something like
image

krivit added a commit to krivit/kableExtra that referenced this issue Mar 6, 2024
@haozhu233
Copy link
Owner

Oh, sure, I can see the use cases of this functionality. That would be great!

@krivit
Copy link
Author

krivit commented Mar 11, 2024

Oh, sure, I can see the use cases of this functionality. That would be great!

Will try to submit in the next week or so. Is there a contribution guidelines and procedures document? Coding style, documentation style, test cases, whether to add myself to contributors in the DESCRIPTION, that sort of thing?

@haozhu233
Copy link
Owner

Thanks! There is no need to rush.

For documentation, it would be great if you can add a short example to the pdf version of the doc. You can also add a test on whether your example runs in the test cases. And yeah, please add yourself as a contributor if you want to be included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants