-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A flood of async_register_repository tasks gets created at startup which slows down the event loop #3535
Comments
Make sure you have read the issue guidelines and that you filled out the entire template. If you have an issue identical to this, do not add comments like "same here", "i have this too", instead add a 👍 reaction to the issue description. Thanks! 👍 |
I'm not sure if these tasks suspend, but if they don't the problem probably goes away if they get created with |
If you enable experimental features, that should no longer be a problem. |
Retesting now |
Sadly enabling experimental features didn't solve it
|
Restarted twice to be sure |
|
git blame says its my fault 🥇 |
Ah 👍 That from the data restore, yes that is still there, its from
|
They don't actually suspend so creating them eagerly fixes the issue because they never get scheduled on the loop |
Right, but that does not yet exist. for entry, repo_data in repositories.items():
if (
entry == "0"
or self.hacs.repositories.is_registered(repository_id=entry)
or repo_data.get("category", category) is None
):
continue
await self.hacs.async_register_repository(
repository_full_name=repo_data["full_name"],
category=repo_data.get("category", category),
check=False,
repository_id=entry,
) |
System Health details
n/a
Checklist
Describe the issue
A flood of async_register_repository tasks gets created at startup which slows down the event loop
Reproduction steps
restart
Debug logs
snip to fix in 65536 limit, it goes on an on
Diagnostics dump
No response
The text was updated successfully, but these errors were encountered: