Cloudwatch: Switching between Metric Search and Metric Query and Code/Builder mode can break labels.

[sarahzinger]

When switching between a Metric Search vs a Metric Query query types in the Cloudwatch Datasource, sometimes labels are altered in weird ways. The same can happen when switching between Code mode and Builder mode:

Screen.Recording.2024-05-09.at.12.01.16.PM.mov

In the video above for example when we make a Metric Query request we get back 2 labels on the alert Resource and Series, then we make a query in Metry Search mode with a different metric name. We then switch back to the original Metric Query which seems to still be there, but when we run that query we see we've lost the additional Resource label.

A similar bug exists when switching back and forth between the code editor and query builder for Metric Query (also seen in video), where the user writes a query in the code mode for Metric Query then they switch to Code mode, the edit code mode to have a broken query, then switch back to builder, and the labels are now broken, where the only way to fix is to start with a fresh query or to fix the broken query in the Code mode.

It might make sense to do what the dialogue says and completely delete previously filled queries and show that dialogue anytime we switch between query types/code modes for now. It would be nice if we could attempt to guess what queries a user is making and smoothly shift from one to another but if we can't do that, maybe better to start with a clean slate each time.