Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard save: Saving incomplete field override config results in unnecessary save diff #87547

Closed
dprokop opened this issue May 9, 2024 · 0 comments · Fixed by #87904
Closed
Labels
internal for issues made by grafanistas team/grafana-dashboards Dashboards squad type/bug
Milestone

Comments

@dprokop
Copy link
Member

dprokop commented May 9, 2024

I think we should try to limit the amount of non-migration based diffs in dashboard if possible. This is one of the examples when we could avoid the Save button getting active when it actually should not:

  1. Create a dashboard with a single panel.
  2. Create a field override in that panel, but DO NOT SPECIFY any properties to override, only configure the matcher.
  3. Save the dashboard (mind, that the incomplete override is saved).
  4. Refresh dashboard page end enter edit mode, click Save dashboard (observe there are changes, incomplete override is removed)
  5. Go to panel edit (observe Save dashboard is active now, incomplete override is removed).
@dprokop dprokop added type/bug internal for issues made by grafanistas labels May 9, 2024
@dprokop dprokop added this to the 11.0.x milestone May 9, 2024
@grafanabot grafanabot added the team/grafana-dashboards Dashboards squad label May 9, 2024
@dprokop dprokop changed the title Dashboard save: Saving incomplete field override config results in unnecessare save diff when refreshed Dashboard save: Saving incomplete field override config results in unnecessary save diff May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal for issues made by grafanistas team/grafana-dashboards Dashboards squad type/bug
Projects
Status: 🚀 Done
Development

Successfully merging a pull request may close this issue.

2 participants