Dashboard scenes: Fix issue going from view panel to edit panel when dashboard is not in edit mode #87487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarkilhed
added
type/bug
area/dashboard
no-backport
oscarkilhed
requested review from
bfmatei and
Sergej-Vlasov
and removed request for
a team
oscarkilhed
changed the title
Sergej-Vlasov
approved these changes
May 8, 2024
oscarkilhed
deleted the
oscark/fix-issue-going-from-view-panel-to-edit-panel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This aligns the new architecture with the old, by always treating entering into edit view, as if we're coming from the dashboard. Before this PR, when entering into the edit view, we would keep the view single panel state in the dashboard scene. This was causing issues by displaying a "view panel" breadcrumb and causing issues cloning the dashboard.
With this change we always treat entering into the edit view as if the user is coming from the dashboard.
Fixes #87412