Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implementation using WorkManager #657

Open
JessHolle opened this issue Mar 15, 2024 · 2 comments
Open

Re-implementation using WorkManager #657

JessHolle opened this issue Mar 15, 2024 · 2 comments

Comments

@JessHolle
Copy link

Google is pressuring those using services for reliable uploads (as this library does) to use WorkManager (or another solution, but primarily WorkManager).

As best I can tell the reason they are doing this is that each work request is registered along with the device state constraints required to execute the work (e.g. having an available network in this case). By doing so, various apps do not need to stay in memory waiting for these conditions but instead can be restarted when those conditions are met.

So apart from getting Google off our backs there does appear to be a benefit to the end user here.

(I have a very similar library except it is a combination of a guaranteed and expedited delivery event stream with chunking/batching upon any send backlog and event attachment files. Applying WorkManager properly seems a bit trickier in that case...)

@trix0
Copy link

trix0 commented Apr 9, 2024

And another reason for this to be a great change would be Unable to start service net.gotev.uploadservice.UploadService@594ea38 with null: android.app.ForegroundServiceStartNotAllowedException: Service.startForeground() not allowed due to mAllowStartForeground false: service makeable.Intempus/net.gotev.uploadservice.UploadService
Where Google again broke the foreground services.
https://issuetracker.google.com/issues/307329994

@gotev
Copy link
Owner

gotev commented Apr 9, 2024

Started some reasoning back in 2021 about this, worth joining the two issues into one: #610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants