Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry support? #814

Open
dkrizic opened this issue Feb 26, 2024 · 3 comments
Open

OpenTelemetry support? #814

dkrizic opened this issue Feb 26, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@dkrizic
Copy link

dkrizic commented Feb 26, 2024

Hi,

would it be possible to integration OpenTelemetry and emit Spans upon request? Using this library here:

https://github.com/open-telemetry/opentelemetry-go

and activate it if e.g. the parameter

--opentelemetry-endpoint

or the environment variable

OPENTELEMETRY_ENDPOINT

is defined.

@gulien gulien added the enhancement New feature or request label Feb 26, 2024
@gulien
Copy link
Collaborator

gulien commented Feb 26, 2024

Hello @dkrizic 👋

It was on my TODO list! I plan to add it, for tracing at least, as metrics is available through Prometheus.

@dkrizic
Copy link
Author

dkrizic commented Feb 26, 2024

Hi @gulien,

regarding Metrics I suggest using the OT library as well. OT covers Metrics as well and Metrics are pushed to the same endpoint.

Regarding Logging: The log should contain trace_id and span_id as well. This allows powerful Log->Trace and Trace->Log.

@gulien
Copy link
Collaborator

gulien commented Feb 26, 2024

Thanks for the details!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants