Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Points only optimization doesn't exist for indexing #294

Open
MBkkt opened this issue Jan 5, 2023 · 6 comments
Open

Points only optimization doesn't exist for indexing #294

MBkkt opened this issue Jan 5, 2023 · 6 comments

Comments

@MBkkt
Copy link
Contributor

MBkkt commented Jan 5, 2023

https://github.com/google/s2geometry/blob/master/src/s2/s2region_term_indexer.cc#L213

It looks like same possible for index terms, am I right?

Why do I need other terms (not true_max_level) if query contains only points?

@MBkkt
Copy link
Contributor Author

MBkkt commented Jan 6, 2023

da93358

@MBkkt
Copy link
Contributor Author

MBkkt commented Jan 6, 2023

#296

@MBkkt
Copy link
Contributor Author

MBkkt commented Jan 6, 2023

@smcallis @jmr What do you think?

@jmr
Copy link
Member

jmr commented Jan 6, 2023

I don't know the algorithm well enough. Since you already implemented this as part of #296, can you write some tests and convince yourself it works? I can look in more detail next week.

@MBkkt
Copy link
Contributor Author

MBkkt commented Jan 6, 2023

Ok!

@smcallis
Copy link
Collaborator

smcallis commented Jan 6, 2023

I'm not familiar with this one either so I'd need some time to familiarize myself. A test case I can use to look at the performance internally would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants