Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing arbitrary flags to run_all_experiments.py via request_pr_exp.py. #245

Open
oliverchang opened this issue May 3, 2024 · 1 comment
Labels

Comments

@oliverchang
Copy link
Collaborator

Currently there is very little control over flags passed to PR experiments:

command: ["/bin/bash", "report/docker_run.sh", "${GKE_EXP_BENCHMARK}", "${GKE_EXP_NAME}", "${GKE_EXP_FUZZING_TIMEOUT}", "ofg-pr", "${GKE_EXP_LLM}", "${GKE_EXP_DELAY}"]

We should ideally support piping arbitrary flags via request_pr_exp.py.

e.g.

request_pr_exp.py -p 123 -n NAME -- --model=foo --context 
@DonggeLiu
Copy link
Collaborator

DonggeLiu commented May 3, 2024

Another issue about docker_run.sh is that it assumes the order of command line args.
This is a good opportunity to upgrade it to a Python script to allow more flexible args.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants