Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n support for dark mode menu button #1987

Open
Tracked by #1944
shiami opened this issue May 3, 2024 · 0 comments
Open
Tracked by #1944

i18n support for dark mode menu button #1987

shiami opened this issue May 3, 2024 · 0 comments
Labels
e0-minutes Effort < 60 min enhancement New feature or request i18n Internationalization / Localization
Milestone

Comments

@shiami
Copy link

shiami commented May 3, 2024

The menu button text "Light", "Dark", "Auto" is hard coded in the file below.
Please add i18n support.
Thanks!

<ul class="dropdown-menu dropdown-menu-end{{ if $isExamples }} shadow{{ end }}" aria-labelledby="bd-theme-text">
<li>
<button type="button" class="dropdown-item d-flex align-items-center" data-bs-theme-value="light" aria-pressed="false">
<svg class="bi me-2 opacity-50"><use href="#sun-fill"></use></svg>
Light
<svg class="bi ms-auto d-none"><use href="#check2"></use></svg>
</button>
</li>
<li>
<button type="button" class="dropdown-item d-flex align-items-center" data-bs-theme-value="dark" aria-pressed="false">
<svg class="bi me-2 opacity-50"><use href="#moon-stars-fill"></use></svg>
Dark
<svg class="bi ms-auto d-none"><use href="#check2"></use></svg>
</button>
</li>
<li>
<button type="button" class="dropdown-item d-flex align-items-center active" data-bs-theme-value="auto" aria-pressed="true">
<svg class="bi me-2 opacity-50"><use href="#circle-half"></use></svg>
Auto
<svg class="bi ms-auto d-none"><use href="#check2"></use></svg>
</button>
</li>
</ul>

@chalin chalin added enhancement New feature or request e0-minutes Effort < 60 min i18n Internationalization / Localization labels May 3, 2024
@chalin chalin added this to the 24Q2 milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e0-minutes Effort < 60 min enhancement New feature or request i18n Internationalization / Localization
Projects
None yet
Development

No branches or pull requests

2 participants