{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":636730689,"defaultBranch":"master","name":"telemetry","ownerLogin":"golang","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2023-05-05T14:07:29.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4314092?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717597392.0","currentOid":""},"activityList":{"items":[{"before":"221703e18637934f3b2a12fa8df1fa96a70fa887","after":"8cad58b3fcbb3ae3578ecc72f5eed440de8a3715","ref":"refs/heads/master","pushedAt":"2024-06-12T19:18:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"telemetry: add MaybeChild, which executes child logic if applicable\n\nIn the Go command, we can't call telemetry.Start as the first thing when\nthe Go command starts because we can't do significant work before\ndoing toolchain switching. On the other hand, we do want to run the\nchild logic if the Go command is running as the telemetry child as the\nfirst thing before doing toolchain selection: the parent has already\nbeen started using the switched toolchain.\n\nAdd a telemetry.MaybeChild function that executes the child code if the\ngo command is running as the child that will be called immediately when\nthe go command starts. Start will continue to check if it's the child\nfor now to avoid breaking current usages of it but we might want to\nremove that code from Start in the future to make things a bit simpler.\n\nThe initialization of the parent/child process that was done by start\nhas now been moved into parent and child. There is limited duplication\n(for example, initializing the telemetry directory) but much of the work\nis different between them. For instance, we don't need to check the mode\nin the child function because it was already checked by the parent\nbefore starting the child.\n\nOne unfortunate consequence of doing this is that the manipulation and\nchecking of the GO_TELEMETRY_CHILD environment variable now happens in\nfour places (EntryPoint, Start, parent, and startChild) rather than two\npreviously (Start and parent)\n\nChange-Id: I3d31e44ee3a141b08ffd87f037f1a03f0513c1cc\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/592017\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"telemetry: add MaybeChild, which executes child logic if applicable"}},{"before":"32e7221350734e46793478938c938ca1953fe4c4","after":"221703e18637934f3b2a12fa8df1fa96a70fa887","ref":"refs/heads/master","pushedAt":"2024-06-07T19:31:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/content: run go generate\n\nIn order to pick up the change CL 585479 we need to renegerate\nthe minified javascript.\n\nA test to detect this automatically will be nice, but\nI am not sure if the Go project CI has all dependency tools\n(esbuild, tsc, ...).\n\nFixes golang/go#67397\n\nChange-Id: If4e6c5cf9d52c273e385a3db4a9bea4726aa7a08\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/591177\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"internal/content: run go generate"}},{"before":"0bb84d54d407ec27ca3ebc5ffdabf4e94f277999","after":"32e7221350734e46793478938c938ca1953fe4c4","ref":"refs/heads/master","pushedAt":"2024-06-07T15:30:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/counter: ensure that file rotation updates metadata\n\nPreviously counter.file.meta was never rewritten, meaning that\nsubsequent mapped files shared the same metadata - even if they have a\ndifferent time span.\n\nFix this clarifying the control flow somewhat, with the following\nrefactorings:\n\n - Simplify cleanup logic in rotate1, using a single deferred func\n literal to handle cleaning up after any state changes. The logic is\n hopefully simpler: if the mapped file changed, ensure that the\n previous file is closed and counters invalidated.\n - Replace fileValidity with weekEnds+counterSpan helper, so that\n helpers have more narrowly scoped concerns.\n - Inline filename and init into rotation, as the indirection obscured\n the file initialization logic.\n - Replace the the file.namePrefix field with file.begin and buildInfo,\n so that file names are only constructed in one place.\n - Build metadata on each call to rotate, if the file date changed.\n\nFixes golang/go#67815\n\nChange-Id: I2930a730df4088f6e14080b7d12b47c196c720f1\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/590338\nReviewed-by: Hyang-Ah Hana Kim \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"internal/counter: ensure that file rotation updates metadata"}},{"before":"0767749d88e7e388d15e65340e61393cb0237d77","after":"0bb84d54d407ec27ca3ebc5ffdabf4e94f277999","ref":"refs/heads/master","pushedAt":"2024-06-05T14:18:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"config: regenerate upload config\n\nThis is an automated CL which updates the generated upload config.\n\nChange-Id: Iae0c484d88cd0e00c32fe29b7b1cba1243e4304b\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/590735\nAuto-Submit: Gopher Robot \nReviewed-by: Robert Findley \nReviewed-by: Zvonimir Pavlinovic \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"config: regenerate upload config"}},{"before":"e7436e9e15128e8a6fc0886b395ce93ae0ed552d","after":"0767749d88e7e388d15e65340e61393cb0237d77","ref":"refs/heads/master","pushedAt":"2024-06-04T17:51:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/chartconfig: add govulncheck counters\n\nFixes golang/go#67678\n\nChange-Id: Idcddf4071297c96ecd5e017b867bee72845919e8\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/588736\nTryBot-Result: Gopher Robot \nRun-TryBot: Zvonimir Pavlinovic \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Hyang-Ah Hana Kim \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"internal/chartconfig: add govulncheck counters"}},{"before":"f2b69109f79bfe2c861f49a44f1691fd80d4b86c","after":"e7436e9e15128e8a6fc0886b395ce93ae0ed552d","ref":"refs/heads/master","pushedAt":"2024-06-04T16:02:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I6bf461980faa90e309e78e749ac44de6bbb6f96a\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/590236\nAuto-Submit: Gopher Robot \nReviewed-by: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"go.mod: update golang.org/x dependencies"}},{"before":"469116581a8ea2aa4335b3f4ff3d78e18871fa2d","after":"f2b69109f79bfe2c861f49a44f1691fd80d4b86c","ref":"refs/heads/master","pushedAt":"2024-06-03T22:45:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/counter: return an error when the weekends file is empty\n\nThis bug manifested in load testing: depending on the nature of races,\nthe weekends file can be empty. An apparent bug caused a nil error to be\nreturned in this case.\n\nAlso fix a mixuse of rotate instead of rotate1.\n\nChange-Id: I69e8e767ee2a49449cd41f62e255659755935652\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/589937\nReviewed-by: Hyang-Ah Hana Kim \nAuto-Submit: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"internal/counter: return an error when the weekends file is empty"}},{"before":"acd60dee2c9943b5c2900e3cf4140d616e20d313","after":"469116581a8ea2aa4335b3f4ff3d78e18871fa2d","ref":"refs/heads/master","pushedAt":"2024-05-31T17:49:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"telemetry: acquire upload token before starting uploader child\n\nInstead of acquiring the upload token after the child is started,\nacquire it before starting the child. Then, if the token isn't acquired\nand crashmonitoring isn't requested, the child doesn't need to be\nstarted at all. The GO_TELEMETRY_UPLOAD environment variable is set to\nindicate to the child that uploading was requested. We need to set the\nenvironment variable (or add some other way to communicate between the\nparent and child such as a command line argument) because if\ncrashmonitoring was also requested the child would have no way of\nknowing if the upload token was acquired.\n\nThe X_TELEMETRY_CHILD environment variable is renamed to\nGO_TELEMETRY_CHILD to make it clear the variable comes from the go\ntoolchain.\n\nFixes golang/go#67700\n\nChange-Id: Ifc0b4ecd8e77711bef1fcb423c96a574aec3ae09\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/589375\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"telemetry: acquire upload token before starting uploader child"}},{"before":"39ace7a40ae7adf90bd106518be3e8d9c21bc6ff","after":"acd60dee2c9943b5c2900e3cf4140d616e20d313","ref":"refs/heads/master","pushedAt":"2024-05-30T20:24:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/configstore: do not require console for subprocess in windows\n\nThe configstore downloads the latest telemetry config using the\n`go mod download` command. The uploader process that calls this\nconfigstore is likely a daemonized process (see x/telemetry/start_windows.go)\nand has no console attached. The console creation behavior when\nthe parent is a console process without console is not clearly\ndocumented anywhere, but empirically we observed a new console\n(new window) is created for the subprocess. I am not sure if this\nis due to the system default configuration, or due to how go's\nos/exec is implemented on windows.\n\nPrevent the new console creation by explicitly setting the\nCREATE_NO_WINDOW attribute.\n https://learn.microsoft.com/en-us/windows/win32/procthread/process-creation-flags\n\nManually tested.\n\nFor golang/go#67660\n\nChange-Id: Ia86ebafe3d4d7bcb63a7eaf9ce01c4eb32b43809\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/589061\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley \nReviewed-by: Michael Matloob ","shortMessageHtmlLink":"internal/configstore: do not require console for subprocess in windows"}},{"before":"2e57a912eafefc904ac735f10bace823128f67ba","after":"39ace7a40ae7adf90bd106518be3e8d9c21bc6ff","ref":"refs/heads/master","pushedAt":"2024-05-22T23:36:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/upload: make upload.Run concurrency safe\n\nFix broken writes by writing upload-related files exclusively. Prevent\nduplicate uploads using a lock file.\n\nFor golang/go#65970\n\nChange-Id: I548134f597b2dbf5232de54027adb3daa4bad53d\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/587197\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Hyang-Ah Hana Kim ","shortMessageHtmlLink":"internal/upload: make upload.Run concurrency safe"}},{"before":"bda55230c457d8271c577c0da94d4b94e3543dd4","after":"2e57a912eafefc904ac735f10bace823128f67ba","ref":"refs/heads/master","pushedAt":"2024-05-22T23:35:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"start,internal/upload: add two tests for concurrent upload\n\nAdd two tests, one for telemetry.Start and an other for upload.Run,\nwhich execute the upload concurrently.\n\nThe test for telemetry.Start succeeds, due to the concurrency safety\nfrom the exclusive acquisition of the upload.token file. The test for\nupload.Run results in incorrect upload counts and occasional invalid\nreport json (due to write shearing). Despite the upload.token guard,\nupload.Run should be more concurrency safe, since there is still a race\ncondition when the upload.token is released. A subsequent CL will add\nmore safeguards.\n\nFor golang/go#65970\n\nChange-Id: Ic7e57b1ee794a58340901289930250bf5114fdf6\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/586141\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Hyang-Ah Hana Kim ","shortMessageHtmlLink":"start,internal/upload: add two tests for concurrent upload"}},{"before":"bf80d5667fb939c1f0c4362cad73293b84c8679e","after":"bda55230c457d8271c577c0da94d4b94e3543dd4","ref":"refs/heads/master","pushedAt":"2024-05-21T20:58:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"godev: update vulnerable dependencies\n\nFound by govulncheck\n\nChange-Id: Ic27c9a0b6d08e010db75113d7bbe936c17b46d5b\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/586197\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Hyang-Ah Hana Kim ","shortMessageHtmlLink":"godev: update vulnerable dependencies"}},{"before":"3f1148c77f691a2dad671242528efc7ea3548f9e","after":"bf80d5667fb939c1f0c4362cad73293b84c8679e","ref":"refs/heads/master","pushedAt":"2024-05-20T20:51:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"telemetry: use debug directory for sidecar logs not local/debug\n\nThe rest of the telemetry code is using the debug subdirectory of the\ntelemetry directory for debug logs. Update the sidecar logs to use the\ndebug subdirectory (instead of local/debug).\n\nChange-Id: Id81fe04d50f0ee1b27decc2d01463c9e63aa24dd\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/586098\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"telemetry: use debug directory for sidecar logs not local/debug"}},{"before":"98772af8589950babe75ed35aab8cca6623a06d7","after":"3f1148c77f691a2dad671242528efc7ea3548f9e","ref":"refs/heads/master","pushedAt":"2024-05-17T18:54:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"godev/cmd/worker: skip empty partition in charts\n\nWhen there is no data to draw, do not include in the charts data.\nPreviously, this resulted in adding null to chartdata > Programs >\nCharts and caused the frontend javascript to throw an exception.\n\nUpdate charts.ts to handle chart json files that contain null charts.\n\nWhile we are here,\n * remove the exception for cmd/go (which does not have version).\n After CL 585198 go toolchain programs will produce counter files\n with the program field filled with the go version.\n * fix the program version handling since now toolchains will have\n version strings that are not semver.\n\nFixes golang/go#67397\n\nChange-Id: I0c037afbbfd931b70ada310dba9d67b49521ad94\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/585479\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"godev/cmd/worker: skip empty partition in charts"}},{"before":"9ff3ad9b3e6802ed3bbc6ef4939986eabab5216b","after":"98772af8589950babe75ed35aab8cca6623a06d7","ref":"refs/heads/master","pushedAt":"2024-05-16T18:59:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"start: when upload && !crashmonitor.Supported(), don't use crashmonitor\n\nCL 585416 in x/tools changed gopls to call telemetry.Start with both\nUpload and ReportCrashes, but a bug in the telemetry.Start logic\nresulted in crashmonitor.Parent being called even when\n!crashmonitor.Supported(), due to a standard disjoint condition error.\n\nFix this by consolidating all handling of telemetry.Config into\ntelemetry.Start, and passing in the derived predicates.\n\nFor golang/go#67430\n\nChange-Id: I2cb4eeae0c98e295af6d531a94090a401f8d0103\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/586195\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Alan Donovan ","shortMessageHtmlLink":"start: when upload && !crashmonitor.Supported(), don't use crashmonitor"}},{"before":"ac8fed89e7752e0bdf9cd721c492058c4396dea2","after":"9ff3ad9b3e6802ed3bbc6ef4939986eabab5216b","ref":"refs/heads/master","pushedAt":"2024-05-15T21:37:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/crashmonitor: pass CrashOptions to SetCrashOutput\n\nNow that CL 585557 has landed in runtime/debug,\nwe can supply the options.\n\nBut we cannot eta-reduce the func literal because\nwe don't want setCrashOutput's type to mention\ndebug.CrashOptions, which is a go1.23-only type.\n\nUpdates golang/go#67182\n\nChange-Id: I2c3b5cbc4594b6bcd5b5ff43c933d0609cc1c309\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/585478\nReviewed-by: Michael Matloob \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"internal/crashmonitor: pass CrashOptions to SetCrashOutput"}},{"before":"74e3e9fbf3418c47cba7b80f76bbae19b5b32494","after":"ac8fed89e7752e0bdf9cd721c492058c4396dea2","ref":"refs/heads/master","pushedAt":"2024-05-15T19:00:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/crashmonitor: prepare for SetCrashOutput signature change\n\nThe function is about to get a second parameter.\nThis shim will be removed later this week.\n\nUpdates golang/go#67182\n\nChange-Id: I166adda831979b713d429504b57510506bfdff11\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/585378\nReviewed-by: Michael Matloob \nAuto-Submit: Alan Donovan \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"internal/crashmonitor: prepare for SetCrashOutput signature change"}},{"before":"f89f2a37392d88b4f9e58c1b6dcb90b1c4bb1806","after":"74e3e9fbf3418c47cba7b80f76bbae19b5b32494","ref":"refs/heads/master","pushedAt":"2024-05-15T17:12:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"upload: eliminate the x/telemetry/upload package\n\nNow that all callers use telemetry.Start, the upload package can be\nremoved. Move Run to internal/upload, and rewrite upload_test to call\nRun rather than NewUploader. At this point, the Uploader type (which\nencapsulates the upload operation) can be made an internal detail.\n\nChange-Id: Ib648017773909849a0534159a548f8c928db2268\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/585477\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Hyang-Ah Hana Kim ","shortMessageHtmlLink":"upload: eliminate the x/telemetry/upload package"}},{"before":"825c3dc71965f2d1292e8f9d1a75a0b157dec057","after":"f89f2a37392d88b4f9e58c1b6dcb90b1c4bb1806","ref":"refs/heads/master","pushedAt":"2024-05-14T22:08:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/crashmonitor: skip TestStart on unsupported platform\n\nSkip TestStart on unsupported platform, and run it in a temp telemetry\ndirectory so as to make the test hermetic, and avoid creating\ncrashmonitor.test counter files in the local telemetry dir.\n\nFixes golang/go#66138\n\nChange-Id: Ie08500f28ca127fa6382b60f59f3b7a16e2a8ee3\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/585375\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Hyang-Ah Hana Kim ","shortMessageHtmlLink":"internal/crashmonitor: skip TestStart on unsupported platform"}},{"before":"3148d7a24f4aff4f343c099a1b8f6a52473613e5","after":"825c3dc71965f2d1292e8f9d1a75a0b157dec057","ref":"refs/heads/master","pushedAt":"2024-05-14T20:11:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"config: regenerate upload config\n\nThis is an automated CL which updates the generated upload config.\n\nChange-Id: I061c42fe414fbff5c64b09e5feb1ab7967696b0a\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/585536\nReviewed-by: Dmitri Shuralyov \nAuto-Submit: Gopher Robot \nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Hyang-Ah Hana Kim ","shortMessageHtmlLink":"config: regenerate upload config"}},{"before":"7d78a974cc44bc5aa6aa5db203e9ab1b3e7ca84c","after":"3148d7a24f4aff4f343c099a1b8f6a52473613e5","ref":"refs/heads/master","pushedAt":"2024-05-14T19:58:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/chartconfig: add missing commas between buckets\n\nA subsequent CL will fix the parsing/validation to ensure that this\nwould have been caught. For now, let's unbreak the config.\n\nUpdates golang/go#67244\n\nChange-Id: I0a867cd7f4547085e6d027f486a069ff8a4e2c4f\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/585376\nReviewed-by: Michael Matloob \nReviewed-by: Hyang-Ah Hana Kim \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Robert Findley ","shortMessageHtmlLink":"internal/chartconfig: add missing commas between buckets"}},{"before":"4a0682cf430de51aba1059af8bd30fb06e7ac4b1","after":"7d78a974cc44bc5aa6aa5db203e9ab1b3e7ca84c","ref":"refs/heads/master","pushedAt":"2024-05-14T18:26:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/chartconfig: add initial cmd/go and cmd/compile counters\n\nThis adds counters for invocations, the buildmode flag and its values\nand cmd/compile bugs.\n\nFixes #67244\n\nChange-Id: Ia6735590879369598a4b5bb272e7e311672c255d\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/584015\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"internal/chartconfig: add initial cmd/go and cmd/compile counters"}},{"before":"609bac32585574e6a274b92f9e21c21efa4a9fbb","after":"4a0682cf430de51aba1059af8bd30fb06e7ac4b1","ref":"refs/heads/master","pushedAt":"2024-05-14T15:30:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/configgen: add special handling for toolchain program versions\n\nMain module version information is not stamped in toolchain binaries,\nand therefore we do not have a program version for toolchain programs.\n\nRather than add special handling for toolchain programs in many places,\nto handle the missing version, instead enforce the convention that for\ntoolchain programs, program version == go version.\n\nSpecifically:\n- Add internal/telemetry.{IsToolchainProgram,ProgramInfo}, to share the\n logic for interrogating program information.\n- Update ProgramInfo to reuse the go version as program version for\n toolchain programs.\n- Update config generation to reuse the go version list as program\n version list, for toolchain programs.\n- Use the go/version package rather than copying it, now that it is\n available. This means that the config generator requires go1.22, which\n should be fine as it is only run by developers or RelUI.\n- Update config generation and validation to use go/version package\n rather than semver package for working with toolchain program\n versions.\n- Move chartconfig.Validate to configgen.ValidateChartConfig, since\n validation now requires the go/version package and requires go1.22\n (chartconfig is linked by more packages).\n\nFor golang/go#67244\n\nChange-Id: I226b18d37e1ad973002b19afa8afdb8cf97b358c\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/585198\nAuto-Submit: Robert Findley \nReviewed-by: Hyang-Ah Hana Kim \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"internal/configgen: add special handling for toolchain program versions"}},{"before":"15c10ceda013637567a72dace7fd7cf80c3d5ff8","after":"609bac32585574e6a274b92f9e21c21efa4a9fbb","ref":"refs/heads/master","pushedAt":"2024-05-14T13:07:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"godev: use Go 1.22 for cloud run services\n\nUpdate the stale Go version in our Dockerfiles, to 1.22.\n\nChange-Id: Id6ed4cc23be68949cec79379d7d2cfe90327c892\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/585255\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Mauri de Souza Meneguzzo \nReviewed-by: Hyang-Ah Hana Kim ","shortMessageHtmlLink":"godev: use Go 1.22 for cloud run services"}},{"before":"800195513ef4884a9eed47a7c5cb95fc275d02a4","after":"15c10ceda013637567a72dace7fd7cf80c3d5ff8","ref":"refs/heads/master","pushedAt":"2024-05-13T21:27:40.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"interal/upload: improve error messages\n\nIf a count file contains no counters, log that fact. If no count\nfile contains counters, say that in the error message.\n\nChange-Id: Ic36564d1dfeab26451435529cbe65343a0ed7bfa\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/585195\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"interal/upload: improve error messages"}},{"before":"243462822d6a428f7f9938a5cfaf4af9953c4698","after":"800195513ef4884a9eed47a7c5cb95fc275d02a4","ref":"refs/heads/master","pushedAt":"2024-05-13T16:40:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/chartconfig: add a test that Load succeeds\n\nChange-Id: I1e37e11509f16b3d27b756492b2461b33ead2dd1\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/585196\nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Robert Findley \nReviewed-by: Michael Matloob ","shortMessageHtmlLink":"internal/chartconfig: add a test that Load succeeds"}},{"before":"51e8b5d718ebd44dc7fec4b97edb963e82b3cdda","after":"243462822d6a428f7f9938a5cfaf4af9953c4698","ref":"refs/heads/master","pushedAt":"2024-05-13T13:49:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/update: make TestRandom less flaky\n\nTestRandom is inherently flaky, being statistical.\nTo reduce the flakiness, only fail with 7 sigma\ndeviations. (The flakiness is only reduced with high\nprobability. It cannot be eliminated.)\n\nFixes: golang/go#66172\nChange-Id: Idf09d245ee2cfcd1db49887a054023a6d675b286\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/584755\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"internal/update: make TestRandom less flaky"}},{"before":"1489fc4c14598082e5187833dffc82663afb163b","after":"51e8b5d718ebd44dc7fec4b97edb963e82b3cdda","ref":"refs/heads/master","pushedAt":"2024-05-10T22:36:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"telemetry: add Dir function for use by go telemetry\n\nAdd a function to get the telemetry directory. It will be used by go clean -telemetry and go env GOTELEMETRYDIR.\n\nChange-Id: I0e2e523929f3e164ea0b6ae584f772c1b1f15c08\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/584304\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"telemetry: add Dir function for use by go telemetry"}},{"before":"150846ee1ff67a929730c7ca3f42845692ee496c","after":"1489fc4c14598082e5187833dffc82663afb163b","ref":"refs/heads/master","pushedAt":"2024-05-10T20:43:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"telemetry: re-enable TestStart at go 1.23\n\nNow that the fix for golang/go#67211 has been vendored into 1.23, we can\nremove the skip for TestStart.\n\nFixes golang/go#67211\n\nChange-Id: I1bc3b5ae3c8619f4d9eb7a58c3aa7c222e6eac2f\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/584796\nReviewed-by: Michael Matloob \nReviewed-by: Hyang-Ah Hana Kim \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"telemetry: re-enable TestStart at go 1.23"}},{"before":"fd5c27b581eaff33c65286a48dad6de481267a9b","after":"150846ee1ff67a929730c7ca3f42845692ee496c","ref":"refs/heads/master","pushedAt":"2024-05-10T20:43:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/upload: migrate TestUploadBasic and TestUploadFailure\n\nMove TestUploadBasic and TestUpload failure to the new upload_test\npackage, and rewrite them to use only the public upload API. This also\ncleans up the file layout a bit, as TestDates is now the only test in\ndates_test.go.\n\nAdditionally, check the state of the telemetry dir before and after\nupload, and generalize TestUploadFailure to a retry test that checks\nvarious status code retry behavior.\n\nFor golang/go#65970\n\nChange-Id: Iab9d33a5eb852b43e7876bbf8b12d91b40c85909\nReviewed-on: https://go-review.googlesource.com/c/telemetry/+/584795\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Hyang-Ah Hana Kim ","shortMessageHtmlLink":"internal/upload: migrate TestUploadBasic and TestUploadFailure"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEY6x0IQA","startCursor":null,"endCursor":null}},"title":"Activity ยท golang/telemetry"}