Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: failed "no write barrier" check compiling "runtime" in TestAbstractOriginSanity #67274

Closed
adonovan opened this issue May 9, 2024 · 2 comments
Closed

cmd/compile: failed "no write barrier" check compiling "runtime" in TestAbstractOriginSanity #67274

adonovan opened this issue May 9, 2024 · 2 comments
Assignees
@adonovan
Labels
compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.23

Comments

@adonovan
Copy link
Member

adonovan commented May 9, 2024 •
edited

See https://go.dev/cl//581215: changes to runtime.throw cause a particular linker test using stronger inlining to fail the "write barrier" static reachability check.
@adonovan adonovan self-assigned this May 9, 2024
@adonovan adonovan added this to the Go1.23 milestone May 9, 2024
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label May 9, 2024
@gopherbot
Copy link

Change https://go.dev/cl/584616 mentions this issue: runtime: add workaround to "throw" pending resolution of issue #67274

gopherbot pushed a commit that referenced this issue May 9, 2024
@thanm @gopherbot
runtime: add workaround to "throw" pending resolution of issue #67274
9eebdca 
Temporarily mark the function runtime.throw as "go:noinline" for the
time being to work around problems introduced by CL 581215. We do not
ordinarily inline runtime.throw unless the build is beind done with an
elevated inline budget (e.g. "-gcflags=-l=4"), so this change should
only have an effect for those special builds.

Updates #67274.

Change-Id: I3811913b8d441e0ddb1d4c7d7297ef23555582a2
Reviewed-on: https://go-review.googlesource.com/c/go/+/584616
Reviewed-by: Alan Donovan <adonovan@google.com>
Auto-Submit: Than McIntosh <thanm@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
@adonovan adonovan changed the title runtime: TestAbstractOriginSanity causes recursive throw in gcmark cmd/compile: failed "no write barrier" check compiling "runtime" in TestAbstractOriginSanity May 9, 2024
@gopherbot
Copy link

Change https://go.dev/cl/584617 mentions this issue: runtime: make convTstring write barrier unreachable from throw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonovan adonovan

Labels
compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.23
Development

No branches or pull requests
2 participants
@adonovan @gopherbot