Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go,x/mod/module: add COM0, LPT0 exclusion for allowed file names #67238

Open
2 tasks
matloob opened this issue May 7, 2024 · 3 comments
Open
2 tasks

cmd/go,x/mod/module: add COM0, LPT0 exclusion for allowed file names #67238

matloob opened this issue May 7, 2024 · 3 comments
Assignees
@matloob
Labels
GoCommand cmd/go modules NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.23

Comments

@matloob
Copy link
Contributor

matloob commented May 7, 2024 •
edited

We need to add COM0 and LPT0 to badWindowsNames in x/mod/module/module.go, but we should also do an analysis to make sure no one's affected, or to send PRs to affected modules to rename files whose name before the extension is COM0 or LPT0.

Steps:
@matloob matloob self-assigned this May 7, 2024
@matloob matloob added NeedsFix The path to resolution is known, but the work has not been done. GoCommand cmd/go modules labels May 7, 2024
@matloob matloob added this to the Go1.23 milestone May 7, 2024
@gopherbot
Copy link

Change https://go.dev/cl/583836 mentions this issue: module: add COM0 and LPT0 to badWindowsNames

gopherbot pushed a commit to golang/mod that referenced this issue May 7, 2024
@matloob
module: add COM0 and LPT0 to badWindowsNames
6686f41 
They have been added to the list of file names that are disallowed on
Windows that's referenced in the comment to badWindowsNames, so add
them to badWindowsNames.

For golang/go#67238
For golang/go#66625

Change-Id: I82e5d70f33330f746783fd22090a3ebaf9408dfc
Reviewed-on: https://go-review.googlesource.com/c/mod/+/583836
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Sam Thanawalla <samthanawalla@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/584335 mentions this issue: cmd: vendor golang.org/x/mod@6686f41

@bjorndm
Copy link

bjorndm commented May 8, 2024

Please look at #67245 . It is debatable if these two file names are really reserved or not on Windows.

gopherbot pushed a commit that referenced this issue May 9, 2024
@matloob
cmd: vendor golang.org/x/mod@6686f41
e2375c4 
To pull in CL 583836

Commands run
    go get golang.org/x/mod@6686f416970d4b8e2f54f521955dee89e6763c4b
    go mod tidy
    go mod vendor

For #67238
For #66625

Change-Id: I77e49706481e068d27072a38d0d2464aa40d2dd0
Cq-Include-Trybots: luci.golang.try:gotip-windows-amd64-longtest,gotip-linux-amd64-longtest
Reviewed-on: https://go-review.googlesource.com/c/go/+/584335
Reviewed-by: Sam Thanawalla <samthanawalla@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matloob matloob

Labels
GoCommand cmd/go modules NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.23
Development

No branches or pull requests
3 participants
@bjorndm @gopherbot @matloob