Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Livereload.js has ES6 code after 2fc0abd #6290

Closed
XhmikosR opened this issue Aug 31, 2019 · 1 comment · Fixed by #12455
Closed

Livereload.js has ES6 code after 2fc0abd #6290

XhmikosR opened this issue Aug 31, 2019 · 1 comment · Fixed by #12455

Comments

@XhmikosR
Copy link
Contributor

XhmikosR commented Aug 31, 2019

The current livereload script is using ES6 features which won't work on IE11 for sure. I believe this is an upstream issue, I will report it there, but on the off chance they don't fix it, it'd be nice to restore IE compatibility for local development.

@XhmikosR
Copy link
Contributor Author

Upstream issue livereload/livereload-js#85

@bep bep added the Upstream label Aug 31, 2019
@bep bep modified the milestones: v0.59, v0.60 Aug 31, 2019
@bep bep modified the milestones: v0.60, v0.61 Oct 21, 2019
@bep bep modified the milestones: v0.61, v0.62, v0.63 Nov 25, 2019
@bep bep modified the milestones: v0.63, v0.64 Dec 11, 2019
@bep bep modified the milestones: v0.64, v0.65 Jan 22, 2020
@bep bep modified the milestones: v0.65, v0.66 Jan 30, 2020
@bep bep modified the milestones: v0.66, v0.67 Mar 2, 2020
@bep bep modified the milestones: v0.67, v0.68 Mar 9, 2020
@bep bep modified the milestones: v0.68, v0.69 Mar 20, 2020
@bep bep modified the milestones: v0.69, v0.70 Apr 8, 2020
@bep bep modified the milestones: v0.70, v0.71 Apr 28, 2020
@bep bep modified the milestones: v0.71, v0.72 May 18, 2020
@bep bep removed this from the v0.72 milestone May 31, 2020
@bep bep modified the milestones: v0.115.0, v0.116.0 Jun 30, 2023
@bep bep modified the milestones: v0.116.0, v0.117.0 Aug 1, 2023
@bep bep modified the milestones: v0.117.0, v0.118.0 Aug 30, 2023
@bep bep modified the milestones: v0.118.0, v0.119.0 Sep 15, 2023
@bep bep modified the milestones: v0.119.0, v0.120.0 Oct 4, 2023
@bep bep modified the milestones: v0.120.0, v0.121.0 Oct 31, 2023
@bep bep modified the milestones: v0.121.0, v0.122.0 Dec 6, 2023
@bep bep modified the milestones: v0.122.0, v0.123.0, v0.124.0 Jan 27, 2024
@bep bep modified the milestones: v0.124.0, v0.125.0 Mar 4, 2024
@bep bep modified the milestones: v0.125.0, v0.126.0 Apr 23, 2024
jmooring added a commit to jmooring/hugo that referenced this issue May 1, 2024
We no longer need a patched version because livereload/livereload-js#84
was merged on 28 Dec 2019.

Closes gohugoio#6290
bep added a commit to bep/hugo that referenced this issue May 2, 2024
This script has very infrequent updates, but just copy pasting the minified source creates some potential trust issues.

This JS will now be pulled from a Git version and both the unminified and minified version gets written to disk.

This way it should be easier to reason about changes in the future.

To upgrade, change the commit hash and run `mage generate`.

Closes gohugoio#12451
Closes gohugoio#6290
bep added a commit to bep/hugo that referenced this issue May 2, 2024
This script has very infrequent updates, but just copy pasting the minified source creates some potential trust issues.

This JS will now be pulled from a Git version and both the unminified and minified version gets written to disk.

This way it should be easier to reason about changes in the future.

To upgrade, change the commit hash and run `mage generate`.

Closes gohugoio#12451
Closes gohugoio#6290
bep added a commit that referenced this issue May 10, 2024
This script has very infrequent updates, but just copy pasting the minified source creates some potential trust issues.

This JS will now be pulled from a Git version and both the unminified and minified version gets written to disk.

This way it should be easier to reason about changes in the future.

To upgrade, change the commit hash and run `mage generate`.

Closes #12451
Closes #6290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants