Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contributors graph respect "Co-authored-by" #29183

Open
6543 opened this issue Feb 15, 2024 · 2 comments · May be fixed by #30925
Open

contributors graph respect "Co-authored-by" #29183

6543 opened this issue Feb 15, 2024 · 2 comments · May be fixed by #30925
Labels
type/enhancement An improvement of existing functionality

Comments

@6543
Copy link
Member

6543 commented Feb 15, 2024 •
edited

the initial implementation ( #27882) does not use the Co-authored-by: information in commit messages.

but especially in repos like e.g. this one, where squash merge is used, you loose a lot of information.

gitea/services/repository/contributors_graph.go

Line 119 in 21331be

func getExtendedCommitStats(repo *git.Repository, revision string /*, limit int */) ([]*ExtendedCommitStats, error) {

has to be extended ...
@6543 6543 added type/bug type/enhancement An improvement of existing functionality and removed type/bug labels Feb 15, 2024
@sahinakkaya
Copy link
Contributor

I actually didn't quite understand what you mean by that line of code has to be extended but I agree a lot of information is lost on squash. I always split my work into meaningful commits so that I could easily revert one of them if it is not needed or introduces a bug. It is not that easy to revert when they are squashed.

@6543
Copy link
Member Author

6543 commented Feb 16, 2024

@sahinakkaya that's not a critic of your work :)

it's a follow up issue that propose to also let authors count who are indicated by Co-authored-by keyword in commit messages :)

@kemzeb kemzeb linked a pull request May 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect Co-authored-by trailers in the contributors graph kemzeb/gitea
2 participants
@6543 @sahinakkaya