format: stop relying on array properties #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are numerous libraries out there (sugarjs, prototypejs) that extend the `Array` prototype. The `simplify` function in js-quantities relies on setting/checking properties on an array instance, which means that it's incompatible with such libraries. Add compatibility by using a separate object for keeping track of the counters instead of using properties on array instances. Fix gentooboontoo#130. Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
| @@ -454,7 +454,9 @@ var UNITS = { | |||
| "<dozen>" : [["doz","dz","dozen"],12.0,"prefix_only", ["<each>"]], | |||
| "<percent>": [["%","percent"], 0.01, "prefix_only", ["<1>"]], | |||
| "<ppm>" : [["ppm"],1e-6, "prefix_only", ["<1>"]], | |||
| "<ppt>" : [["ppt"],1e-9, "prefix_only", ["<1>"]], | |||
| "<ppb>" : [["ppb"],1e-9, "prefix_only", ["<1>"]], | |||
There was a problem hiding this comment.
These (beyond million) only make sense in the places like the US where 1 billion == 1 thousand million, not in places like the UK where 1 billion == 1 million million.
There was a problem hiding this comment.
Please ignore the generated files. I did not write this code, but they weren't .gitignored so I felt like I should include them. If you think there are issues here, you might consider logging one since these things were already here.
| @@ -454,7 +454,9 @@ var UNITS = { | |||
| "<dozen>" : [["doz","dz","dozen"],12.0,"prefix_only", ["<each>"]], | |||
| "<percent>": [["%","percent"], 0.01, "prefix_only", ["<1>"]], | |||
| "<ppm>" : [["ppm"],1e-6, "prefix_only", ["<1>"]], | |||
| "<ppt>" : [["ppt"],1e-9, "prefix_only", ["<1>"]], | |||
| "<ppb>" : [["ppb"],1e-9, "prefix_only", ["<1>"]], | |||
| "<ppt>" : [["ppt"],1e-12, "prefix_only", ["<1>"]], | |||
There was a problem hiding this comment.
Another ambiguous term: parts per trillion or parts per thousand? (and if trillion: US trillion or UK trillion)
| "<ppt>" : [["ppt"],1e-9, "prefix_only", ["<1>"]], | ||
| "<ppb>" : [["ppb"],1e-9, "prefix_only", ["<1>"]], | ||
| "<ppt>" : [["ppt"],1e-12, "prefix_only", ["<1>"]], | ||
| "<ppq>" : [["ppq"],1e-15, "prefix_only", ["<1>"]], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are numerous libraries out there (sugarjs, prototypejs) that extend the
Arrayprototype. Thesimplifyfunction in js-quantities relies on setting/checking properties on an array instance, which means that it's incompatible with such libraries. This PR fixes #130, adding compatibility by using a separate object for keeping track of the counters instead of using properties on array instances.Note: It was unclear whether I should be including changes to generated files. Please let me know if I should only be changing the src/spec files and I can update this PR.