Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The behavior when using selectCurrentPageOnly #12781

Closed
bzy107 opened this issue May 14, 2024 · 0 comments · Fixed by #12853
Closed

The behavior when using selectCurrentPageOnly #12781

bzy107 opened this issue May 14, 2024 · 0 comments · Fixed by #12853
Labels
Milestone

Comments

@bzy107
Copy link
Contributor

bzy107 commented May 14, 2024

Package

filament/filament

Package Version

v3.2.78

Laravel Version

v11.0.7

Livewire Version

v3.4.10

PHP Version

PHP8.3.7

Problem description

When selectCurrentPageOnly is used, if the same number of items as the pagination count are checked across pages, the "select all :count" display disappears.

Expected behavior

When selectCurrentPageOnly is used, I think the checks should not be counted across pagination.

Steps to reproduce

  1. On the first page, check fewer items than the number of items displayed.
  2. On the second page, check enough items to make the total equal to the number of items displayed.
    As a result, the "select all :count" display disappears.

As shown in the video

2024-05-14.21.41.53.mov

Reproduction repository

https://github.com/bzy107/filament-select-bug

Relevant log output

No response

@bzy107 bzy107 added bug Something isn't working medium priority unconfirmed labels May 14, 2024
@danharrin danharrin added this to the v3 milestone May 15, 2024
dev-idkwhoami added a commit to dev-idkwhoami/filament that referenced this issue May 18, 2024
Due to the amount of selected records matching across multiple pages while 'selectCurrentPageOnly()' is set.

Related Issue: filamentphp#12781
@danharrin danharrin linked a pull request May 20, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants