Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: provide nested data for otherFormes #902

Open
1 task done
favna opened this issue Dec 15, 2023 · 0 comments
Open
1 task done

request: provide nested data for otherFormes #902

favna opened this issue Dec 15, 2023 · 0 comments

Comments

@favna
Copy link
Member

favna commented Dec 15, 2023

Is there an existing issue or pull request for this?

  • I have searched the existing issues and pull requests

Feature description

Currently the otherFormes field for a Pokemon is an array of strings, however, this field could be a nested reference to the actual Pokémon. This is currently blocked by #900 as v8 cannot handle so much data, but once that issue is resolved this should be changed.

Desired solution

  • The otherFormes should be a [Pokemon!] type instead of a [String!] type
  • The mappers should be updated to match

Alternatives considered

N.A.

Additional context

The bulk of the changes are already done in #899.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant