-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
DS Implementation - SkipNav #12929
Comments
Could you assign me, please? |
@wackerow I want to work on this issue, once the Figma design is updated. |
@murluki are you able to do the Figma design proposal? |
@nloureiro yes, I can help you with this. |
great! will you create a Figma file? or do you want me to create one. |
@murluki just to clarify, are you doing the design and the implementation in the code? or just the design part? assigning to you in the meantime. |
@nloureiro could you please create the Figma file? |
go for it!!! Thank you for your collaboration |
@pettinarip @murluki I updated this issue's description to give better clarity in describing what Chakra's |
Hi I would like to help out on this, is it possible to assign me also to this? |
@surajpsuresh Hi, I am actually done with it and will be pushing it tonight |
Okay cool |
@murluki Is it possible to talk to you regarding contributing, best practices and how to actually share design work on GitHub. Any time that is convenient for you would work! Cheers! |
@surajpsuresh of course, if you have telegram, hit me up at murluki_prg. I can share some tips with you :) |
Done |
@murluki and @surajpsuresh you may reach out to me if you need any clarification of the requirements! 馃榿 |
Sure @TylerAPfledderer will do, I guess @murluki has completed this for now, keeping an eye out for any new design tasks that may pop up. |
馃毃As of the initial posting of this issue, a new design needs to be created in Figma by @nloureiro before executing this update. The issue can still be assigned by a contributor in the meantime.
Update the existing
SkipNav
component to use a new design.Currently, this component is fully custom in it's styles and handling of the link redirect to content in the given page. Recommend investigating the use of the SkipNavLink and SkipNavContent provided by Chakra to handle in consideration of accessibility.
Be aware that
SkipNavLink
under the hood renders a primitivea
tag with needed logic passed to it. We should retain this render, as its only job is to send the user to the specified section of content.It also has it's own theme config
SkipLink
. See source code.In summary of initial recommendations:
SkipLink
file in favor of keeping styling in the component theme configurationhref
can be supplied at the parent levelRootLayout
.SkipNavLink
/SkipNavContent
directly from Chakracc @pettinarip Do NOT assign me! 馃槄
The text was updated successfully, but these errors were encountered: