New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Prow slack messages to SIG-etcd channel #17882
Comments
@liangyuanpeng are you saying that these notifications are from k/k, but are available in a different slack, as in not Kubernetes slack? |
correct, It's working with https://slack.github.com/ . |
Discussed during sig-etcd triage meeting. We agreed this would be helpful, however we need to understand which types of notifications we would want to receive. If this will be channel based we agreed a separate channel would be best so everyone can opt in to receiving them. I think we need to review the configuration for the slack plugin https://github.com/kubernetes/test-infra/blob/master/config/prow/plugins.yaml#L359 and understand the capabilities. |
Adding Slack Reporter doc here as it seems relevant. It is not exactly a plugin but a crier to post job statuses in a given slack channel for a given set of prowjobs. |
Stepping back from the solutions for a moment I just want to make sure we are clear on what we are requesting so we can then make a good decision about how to achieve it, based on the discussion at triage today we had:
This would be a good starting point I think. Another potentially useful notification would be failures for Ideally we would configure which repositories send notifications as code. If anyone has ideas to do something different than what I have described above or any objections please reply below. If you have time to investigate some options @ArkaSaha30 please take a look 🙏🏻 |
@liangyuanpeng well, if you want to use slack.github.com there's nothing preventing that. Does the project want that though? |
What would you like to be added?
Consider enabling the Prow plugin to message #sig-etcd or a new channel with Slack messages around PRs, merges, and test failures.
Why is this needed?
Per #16890, some contributors would like to add repo messages to Slack. Kubernetes slack does this via Prow plugins. If we want this, then that's what we need to enable.
This opens up the questions of:
Please discuss.
The text was updated successfully, but these errors were encountered: