Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Prow slack messages to SIG-etcd channel #17882

Open
jberkus opened this issue Apr 25, 2024 · 7 comments
Open

Enable Prow slack messages to SIG-etcd channel #17882

jberkus opened this issue Apr 25, 2024 · 7 comments
Labels
area/community priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. type/feature

Comments

@jberkus
Copy link

jberkus commented Apr 25, 2024

What would you like to be added?

Consider enabling the Prow plugin to message #sig-etcd or a new channel with Slack messages around PRs, merges, and test failures.

Why is this needed?

Per #16890, some contributors would like to add repo messages to Slack. Kubernetes slack does this via Prow plugins. If we want this, then that's what we need to enable.

This opens up the questions of:

  1. Do we want repository activity messages in Slack?
  2. Do we want them in the main #sig-etcd channel, or in a new channel?

Please discuss.

@liangyuanpeng
Copy link
Contributor

liangyuanpeng commented Apr 26, 2024

Maybe k/k also have enabled the slack app in github org? Because I am listening to k/k event notifications through github slack. And this method allows users to subscribe to events from anywhere. In my case, I listen for k/k event notifications in my own slack channel.

See

image

@jberkus
Copy link
Author

jberkus commented Apr 26, 2024

@liangyuanpeng are you saying that these notifications are from k/k, but are available in a different slack, as in not Kubernetes slack?

@liangyuanpeng
Copy link
Contributor

are you saying that these notifications are from k/k, but are available in a different slack, as in not Kubernetes slack?

correct, It's working with https://slack.github.com/ .

@jmhbnz jmhbnz added area/community priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels May 6, 2024
@jmhbnz
Copy link
Member

jmhbnz commented May 9, 2024

Discussed during sig-etcd triage meeting. We agreed this would be helpful, however we need to understand which types of notifications we would want to receive. If this will be channel based we agreed a separate channel would be best so everyone can opt in to receiving them.

I think we need to review the configuration for the slack plugin https://github.com/kubernetes/test-infra/blob/master/config/prow/plugins.yaml#L359 and understand the capabilities.

@ArkaSaha30
Copy link
Contributor

Adding Slack Reporter doc here as it seems relevant. It is not exactly a plugin but a crier to post job statuses in a given slack channel for a given set of prowjobs.
At first glance, it seems like tweaking it can serve our purpose. If this is a viable option I am ready to take it up 🤚

@jmhbnz
Copy link
Member

jmhbnz commented May 10, 2024

Stepping back from the solutions for a moment I just want to make sure we are clear on what we are requesting so we can then make a good decision about how to achieve it, based on the discussion at triage today we had:

  • A new slack channel to be created for etcd notifications
  • Automated notifications to be sent to the channel for issue or pr creation

This would be a good starting point I think. Another potentially useful notification would be failures for scheduled or postsubmit etcd prow jobs.

Ideally we would configure which repositories send notifications as code. If anyone has ideas to do something different than what I have described above or any objections please reply below.

If you have time to investigate some options @ArkaSaha30 please take a look 🙏🏻

@jberkus
Copy link
Author

jberkus commented May 11, 2024

@liangyuanpeng well, if you want to use slack.github.com there's nothing preventing that. Does the project want that though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/community priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. type/feature
Development

No branches or pull requests

4 participants