-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPS method estimation error #9
Comments
I cut out 2.4 to 4.0 seconds, which should be E4 = 329.63 Hz:
So it looks like it's working to me. It's off by 1.3 Hz in the worst case, not 10 Hz.
|
Looks like I should also have de-meaned the spectra before summing them. HPS function was only half-finished |
Possibly fixed in 12325d5? |
Have you tried it since I fixed the bug in HPS? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am using
freq_from_hps
as described here to detect pitch in monophonic guitar samples.I noticed that the results I get often have a slight estimation error which is always +10-15Hz. For example, when I want to detect pitch for this audio file (see end of post for the correct pitches) I get:
[['F4'], ['F#4'], ['G4'], ['G#4'], ['A4'], ['A4'], ['A#4'], ['B4'], ['C5'], ['C#5'], ['D5'], ['D#5'], ['E5'], ['F5'], ['F#5'], ['G5'], ['G#5'], ['A5'], ['A#5'], ['B5'], ['C6'], ['C#6'], ['F4']]
When I increase every of these pitches by 10Hz I get:
[['E4'], ['F4'], ['F#4'], ['G4'], ['G#4'], ['A4'], ['A#4'], ['B4'], ['C5'], ['C#5'], ['D5'], ['D#5'], ['E5'], ['F5'], ['F#5'], ['G5'], ['G#5'], ['A5'], ['A#5'], ['B5'], ['C6'], ['C#6'], ['E4']]
Which is actually 100% correct.
This basically happens for almost every note below G#4 (and above E2). What could be the issue here? Any ideas about how there is such a fixed estimation error?
Furthermore, as I am designing this application specifically for the guitar, do you have any recommendations/tips as to how I could optimise this method?
Thanks.
The text was updated successfully, but these errors were encountered: