Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC Activator #32

Open
sleipnir opened this issue Sep 9, 2022 · 2 comments
Open

Add gRPC Activator #32

sleipnir opened this issue Sep 9, 2022 · 2 comments
Labels
activators enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@sleipnir
Copy link
Member

sleipnir commented Sep 9, 2022

It would be nice if this elixir-grpc/grpc#254 was implemented before we start this item

We need to dynamically implement a grpc contract, just like we did in the Massa project, for the client for this we need at runtime to compile the proto files via FileDescriptor

Example of converting protobuf json to elixir (pseudo code):

actor = Eigr.Functions.Protocol.Actors.Actor.new(name: "Joe")
{:ok, json} = Protobuf.JSON.to_encodable(actor)
decoded_actor = Protobuf.JSON.decode(json, Eigr.Functions.Protocol.Actors.Actor)

Links:
https://github.com/eigr/massa/blob/379828098fbbb7298de5ebd8ee1525c749555bbd/apps/massa_proxy/lib/massa_proxy/server/grpc_server.ex#L18
https://github.com/eigr/massa/blob/379828098fbbb7298de5ebd8ee1525c749555bbd/apps/massa_proxy/lib/massa_proxy/server/grpc_server.ex#L32
https://github.com/eigr/massa/blob/379828098fbbb7298de5ebd8ee1525c749555bbd/apps/massa_proxy/lib/massa_proxy/util.ex#L155

@sleipnir sleipnir added enhancement New feature or request good first issue Good for newcomers activators labels Sep 9, 2022
@sleipnir sleipnir added this to the v1.0.0 milestone Sep 9, 2022
@sleipnir
Copy link
Member Author

With the possibility of transcoding grpc to http (elixir-grpc/grpc#273) maybe we can solve the item #31 through this one.

@sleipnir
Copy link
Member Author

When completes #302 closes this issue without the need for an Activator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
activators enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant